Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[macOS] Eliminate explicit main window init() #40695

Merged
merged 1 commit into from
Mar 28, 2023
Merged

[macOS] Eliminate explicit main window init() #40695

merged 1 commit into from
Mar 28, 2023

Conversation

cbracken
Copy link
Member

@cbracken cbracken commented Mar 28, 2023 •
edited
Loading

The style guide actively recommends against calling .init(). See: https://google.github.io/swift/#initializers-1

No additional tests since this is purely a style change (in a comment, no less) with no semantic effect.

Related framework change: flutter/flutter#123571

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@cbracken cbracken requested a review from hellohuanlin March 28, 2023 00:41
@cbracken
[macOS] Eliminate explicit main window init()
d1e6d64 
The style guide actively recommends against calling .init().
See: https://google.github.io/swift/#initializers-1

No additional tests since this is purely a style change with no semantic effect.

See: flutter/flutter#123571
hellohuanlin
hellohuanlin approved these changes Mar 28, 2023
View reviewed changes
Copy link
Contributor

@hellohuanlin hellohuanlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Style change no need test.

@cbracken cbracken added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 28, 2023
@auto-submit auto-submit bot merged commit 938597a into flutter:main Mar 28, 2023
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 28, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 28, 2023
@engine-flutter-autoroll
938597a6c [macOS] Eliminate explicit main window init() (flutter/engi…
d99d6c4 
…ne#40695)
@cbracken cbracken deleted the remove-init branch March 28, 2023 02:43
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Mar 28, 2023
@engine-flutter-autoroll
938597a6c [macOS] Eliminate explicit main window init() (flutter/engi…
762ff6c 
…ne#40695) (#123577)

Roll Flutter Engine from 83fa712e2ee8 to 938597a6cb36 (1 revision)
sourcegraph-bot pushed a commit to sgtest/megarepo that referenced this pull request Mar 28, 2023
flutter: 938597a6c [macOS] Eliminate explicit main window init() (flu…
cd6b76a 
…tter/engine#40695) (#123577)

Commit: 762ff6c97cbc2f6faeba02a11fbf459316623ff3
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 28, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 28, 2023
@engine-flutter-autoroll
762ff6c 938597a6c [macOS] Eliminate explicit main window init() (flut…
5b02b15 
…ter/engine#40695) (flutter/flutter#123577)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 28, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 28, 2023
@engine-flutter-autoroll
762ff6c 938597a6c [macOS] Eliminate explicit main window init() (flut…
c4eed23 
…ter/engine#40695) (flutter/flutter#123577)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 28, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 28, 2023
@engine-flutter-autoroll
762ff6c 938597a6c [macOS] Eliminate explicit main window init() (flut…
837f415 
…ter/engine#40695) (flutter/flutter#123577)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 28, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 28, 2023
@engine-flutter-autoroll
762ff6c 938597a6c [macOS] Eliminate explicit main window init() (flut…
aa18ff8 
…ter/engine#40695) (flutter/flutter#123577)
This was referenced Mar 28, 2023
Merged
Merged
@reidbaker reidbaker mentioned this pull request Apr 5, 2023
Merged
8 tasks
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
@engine-flutter-autoroll
762ff6c 938597a6c [macOS] Eliminate explicit main window init() (flut…
15544f4 
…ter/engine#40695) (flutter/flutter#123577)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
@engine-flutter-autoroll
762ff6c 938597a6c [macOS] Eliminate explicit main window init() (flut…
837ed04 
…ter/engine#40695) (flutter/flutter#123577)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hellohuanlin hellohuanlin hellohuanlin approved these changes

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App platform-macos
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cbracken @hellohuanlin