[Impeller] migrate texture fill shaders to half precision. #40735
Conversation
chinmaygarde
changed the title
jonahwilliams
added
the
autosubmit
| /// | ||
| /// This is useful for Impeller graphics backend that don't have native support | ||
| /// for Decal. | ||
| f16vec4 IPSampleWithTileModeHf(f16sampler2D tex, |
There was a problem hiding this comment.
Maybe IPHalfSampleWithTileMode to follow the pattern of putting the type info near the beginning? Not sure the best route to go for this, but this is public and available to Flutter users as well. We should probably document some kind of convention for these at some point.
There was a problem hiding this comment.
I thought we only exported runtime effect?
There was a problem hiding this comment.
At a certain point though, we'll probably drop this and only have a half precision verison.
auto-submit
bot
removed
the
autosubmit
|
auto label is removed for flutter/engine, pr: 40735, due to - The status or check suite Linux linux_web_engine has failed. Please fix the issues identified (or deflake) before re-applying this label.
|
jonahwilliams
added
the
autosubmit
|
Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change). If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review. |
…123664) * 1d506dfd7 [Impeller] Allow metal shaders to compile through SPIR-V with openGL semantics. (flutter/engine#40616) * 3287e2b36 [Impeller] support half precision uniforms and half precision samplers (flutter/engine#40590) * 5c1c07fba Revert "Revert "Reland "Default the CanvasKit base URL to local artifacts. (#40293)" (#40470)" (#40700)" (flutter/engine#40717) * 9e4cedc81 Forward stdout and stderr from dart2wasm when verbose. (flutter/engine#40731) * 6941c1820 [Impeller] Allow toggling vulkan validation using a command line test flag. (flutter/engine#40728) * 6ef595829 Roll buildroot to build CanvasKit for speed instead of code size (flutter/engine#40737) * 5b8e02479 [Impeller] Gaussian blur: Add alpha mask specialization (flutter/engine#40707) * 6852bea71 Roll Skia from 7311e9220faf to e3eeabb14e9c (4 revisions) (flutter/engine#40745) * 235e42bea Add an option to malioc_diff.py to print a unified diff (flutter/engine#40732) * 38e6d772f Roll Dart SDK from 1acd1e649fb7 to 69867ba60bb7 (2 revisions) (flutter/engine#40738) * d81c4f2c7 [Impeller] migrate texture fill shaders to half precision. (flutter/engine#40735)
Work towards flutter/flutter#115044