This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Revert "[iOS] Send connectionClosed message when resignFirstResponder to ensure framework focus state is correct." #40777
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LongCatIsLooong
approved these changes
Mar 30, 2023
luckysmg
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 30, 2023
…tResponder to ensure framework focus state is correct. (flutter#40703)" (flutter/engine#40777)
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Mar 30, 2023
…tResponder to ensure framework focus state is correct. (#40703)" (flutter/engine#40777) (#123760) Roll Flutter Engine from 14e536b8c29c to 75fabbecbe1f (1 revision)
sourcegraph-bot
pushed a commit
to sgtest/megarepo
that referenced
this pull request
Mar 30, 2023
…esignFirstResponder to ensure framework focus state is correct. (#40703)" (flutter/engine#40777) (#123760) Commit: fe7b6715be6faf5e44b9ee7fdaa9f77ef1cc0753
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 30, 2023
…signFirstResponder to ensure framework focus state is correct. (#40703)" (flutter/engine#40777) (flutter/flutter#123760)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 30, 2023
…signFirstResponder to ensure framework focus state is correct. (#40703)" (flutter/engine#40777) (flutter/flutter#123760)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 30, 2023
…signFirstResponder to ensure framework focus state is correct. (#40703)" (flutter/engine#40777) (flutter/flutter#123760)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 30, 2023
…signFirstResponder to ensure framework focus state is correct. (#40703)" (flutter/engine#40777) (flutter/flutter#123760)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 30, 2023
…signFirstResponder to ensure framework focus state is correct. (#40703)" (flutter/engine#40777) (flutter/flutter#123760)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 30, 2023
…signFirstResponder to ensure framework focus state is correct. (#40703)" (flutter/engine#40777) (flutter/flutter#123760)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 31, 2023
…signFirstResponder to ensure framework focus state is correct. (#40703)" (flutter/engine#40777) (flutter/flutter#123760)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 31, 2023
…signFirstResponder to ensure framework focus state is correct. (#40703)" (flutter/engine#40777) (flutter/flutter#123760)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 31, 2023
…signFirstResponder to ensure framework focus state is correct. (#40703)" (flutter/engine#40777) (flutter/flutter#123760)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 31, 2023
…signFirstResponder to ensure framework focus state is correct. (#40703)" (flutter/engine#40777) (flutter/flutter#123760)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 31, 2023
…signFirstResponder to ensure framework focus state is correct. (#40703)" (flutter/engine#40777) (flutter/flutter#123760)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 31, 2023
…signFirstResponder to ensure framework focus state is correct. (#40703)" (flutter/engine#40777) (flutter/flutter#123760)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 31, 2023
…signFirstResponder to ensure framework focus state is correct. (#40703)" (flutter/engine#40777) (flutter/flutter#123760)
8 tasks
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 1, 2023
…signFirstResponder to ensure framework focus state is correct. (#40703)" (flutter/engine#40777) (flutter/flutter#123760)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 1, 2023
…signFirstResponder to ensure framework focus state is correct. (#40703)" (flutter/engine#40777) (flutter/flutter#123760)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 1, 2023
…signFirstResponder to ensure framework focus state is correct. (#40703)" (flutter/engine#40777) (flutter/flutter#123760)
8 tasks
exaby73
pushed a commit
to NevercodeHQ/flutter
that referenced
this pull request
Apr 17, 2023
…tResponder to ensure framework focus state is correct. (flutter#40703)" (flutter/engine#40777) (flutter#123760) Roll Flutter Engine from 14e536b8c29c to 75fabbecbe1f (1 revision)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 10, 2023
…signFirstResponder to ensure framework focus state is correct. (#40703)" (flutter/engine#40777) (flutter/flutter#123760)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 10, 2023
…signFirstResponder to ensure framework focus state is correct. (#40703)" (flutter/engine#40777) (flutter/flutter#123760)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #40703
I found that since the
connectionClosedwill invoke_finalizeEditing(TextInputAction.done, shouldUnfocus: true);.This will invoke onSubmit.....But actually we do expect just unfocus and do not expect any submit.. This will cause some break change. Need to have further invesigate to reland