-
Notifications
You must be signed in to change notification settings - Fork 6k
[Impeller] Skip TextRotated golden test. #40818
Conversation
This test ends up with small differences depending on which mac host it runs on and will end up blocking rollers.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The insight from the Skia team was that the golden tests were to be verified out of band by the triagers and not in the critical path for rollers. Perhaps we should follow a similar approach. The test is unlikely to ever offer pixel perfect reproducibility but disabling it gives us nothing. Disabling the test entirely to appease the roller is perhaps throwing the baby out with the bathwater.
LGTM if this is to get the rollers going but we should consider holding doing this and instead stop the rollers from tripping on goldens.
/cc @Piinks - right now the golden checker blocks submit AFAIU by keeping a check as pending until images are triaged. I think this works reasonably well for the framework, but not as well for this case. Maybe we can brainstorm some ways to make this be non-blocking for rollers in the engine. |
(and yes, the goal of this PR is to make sure rollers don't get stuck on golden approvals) |
@chinmaygarde @dnfield there is parameter when we submit to skia gold about how strict we want the golden test to be. We could potentially lower the threshold. |
I think on some platforms this is already done (web I think?) via the fuzzy matching algorithm. So we could add it for the mac platform probably. @mdebbar knows better the config for the engine Gold instance |
I'd rather just follow the Skia GPU teams recommendations on their use of Gold and have this be out of band. |
This test ends up with small differences depending on which mac host it runs on and will end up blocking rollers.