This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Revert "[Impeller] reduce advanced blend subpass count for single input with foreground color" #40914
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Applied to subpass: Correct
Applied directly to contents: Incorrect
|
zanderso
approved these changes
Apr 4, 2023
jonahwilliams
added
the
autosubmit
|
I think these checks are stuck for unrelated reasons. Since this is a revert I'm just going to manually merge. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 4, 2023
…single input with foreground color" (flutter/engine#40914)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 4, 2023
…single input with foreground color" (flutter/engine#40914)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #40886
This renders incorrectly when applied directly to contents instead of as a filter, essentially due to some transform mis handling.
The code only works when the snapshot has an identity transform, which is only true as a subpass