Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[Impeller] Fix coverage values when a stroked path is rotated #40917

Merged
merged 8 commits into from
Apr 5, 2023

Conversation

dnfield
Copy link
Contributor

@dnfield dnfield commented Apr 4, 2023

Fixes flutter/flutter#124131

If the matrix has negative values in it, we were deflating the coverage rect.

@dnfield dnfield requested review from bdero and jonahwilliams April 4, 2023 17:51
Copy link
Member

@bdero bdero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dnfield dnfield added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 4, 2023
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Apr 4, 2023
@auto-submit
Copy link
Contributor

auto-submit bot commented Apr 4, 2023

auto label is removed for flutter/engine, pr: 40917, due to - This commit is not mergeable and has conflicts. Please rebase your PR and fix all the conflicts.

@dnfield dnfield added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 4, 2023
@flutter-dashboard
Copy link

Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change).

If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review.

Changes reported for pull request #40917 at sha 0ab790f

@dnfield
Copy link
Contributor Author

dnfield commented Apr 5, 2023

@gaaclarke - it looks like the playground test draws against a black background, but the golden test against a white one...

@flutter-dashboard
Copy link

Golden file changes are available for triage from new commit, Click here to view.

Changes reported for pull request #40917 at sha 89e24d7

@auto-submit auto-submit bot merged commit 53e0615 into flutter:main Apr 5, 2023
@dnfield dnfield deleted the rotate_color branch April 5, 2023 21:21
@gaaclarke
Copy link
Member

@gaaclarke - it looks like the playground test draws against a black background, but the golden test against a white one...

It's just how transparent is interpreted between the viewers.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
autosubmit Merge PR when tree becomes green via auto submit App will affect goldens
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using a color filter on a rotated canvas results in unexpected clipping
3 participants