-
Notifications
You must be signed in to change notification settings - Fork 6k
[Impeller] Fix coverage values when a stroked path is rotated #40917
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
auto label is removed for flutter/engine, pr: 40917, due to - This commit is not mergeable and has conflicts. Please rebase your PR and fix all the conflicts. |
Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change). If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review. |
@gaaclarke - it looks like the playground test draws against a black background, but the golden test against a white one... |
Golden file changes are available for triage from new commit, Click here to view. |
It's just how transparent is interpreted between the viewers. |
Fixes flutter/flutter#124131
If the matrix has negative values in it, we were deflating the coverage rect.