Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Fix UIWindowSceneGeometryPreferencesIOS leak #40957

Merged
merged 1 commit into from
Apr 7, 2023
Merged

Fix UIWindowSceneGeometryPreferencesIOS leak #40957

merged 1 commit into from
Apr 7, 2023

Conversation

jmagman
Copy link
Member

@jmagman jmagman commented Apr 5, 2023

Fixes flutter/flutter#124288

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@jmagman jmagman self-assigned this Apr 5, 2023
jmagman
jmagman commented Apr 5, 2023
View reviewed changes
shell/platform/darwin/ios/framework/Source/FlutterViewControllerTest.mm
Comment on lines +1344 to +1345
__block __weak id weakPreferences;
@autoreleasepool {
Copy link
Member Author

@jmagman jmagman Apr 5, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most of this file change is whitespace, but this is new.

shell/platform/darwin/ios/framework/Source/FlutterViewControllerTest.mm
Comment on lines +1387 to +1390
[mockWindowScene stopMocking];
[deviceMock stopMocking];
[mockApplication stopMocking];
XCTAssertNil(weakPreferences);
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And these two line changes are new.

@jmagman jmagman mentioned this pull request Apr 5, 2023
Merged
8 tasks
@flutter-dashboard
Copy link

Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change).

If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review.

Changes reported for pull request #40957 at sha 5606040

hellohuanlin
hellohuanlin approved these changes Apr 6, 2023
View reviewed changes
Copy link
Contributor

@hellohuanlin hellohuanlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for cleaning this up

@jmagman jmagman mentioned this pull request Apr 6, 2023
Closed
@jmagman jmagman added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 6, 2023
cyanglaz
cyanglaz approved these changes Apr 6, 2023
View reviewed changes
Copy link
Contributor

@cyanglaz cyanglaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@jmagman
Copy link
Member Author

jmagman commented Apr 6, 2023

I don't know why flutter-gold is even running for this commit, nor why it's stuck pending. Filed flutter/flutter#124295.

@jmagman jmagman merged commit d1dad6a into flutter:main Apr 7, 2023
@jmagman jmagman deleted the UIWindowSceneGeometryPreferencesIOS-leak branch April 7, 2023 01:31
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 7, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 7, 2023
@engine-flutter-autoroll
d1dad6acb Fix UIWindowSceneGeometryPreferencesIOS leak (flutter/engin…
5b0f2e1 
…e#40957)
zhongwuzw pushed a commit to zhongwuzw/engine that referenced this pull request Apr 14, 2023
@jmagman @zhongwuzw
Fix UIWindowSceneGeometryPreferencesIOS leak (flutter#40957)
1dd6219
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cyanglaz cyanglaz cyanglaz approved these changes

@hellohuanlin hellohuanlin hellohuanlin approved these changes

Assignees

@jmagman jmagman

Labels
autosubmit Merge PR when tree becomes green via auto submit App platform-ios will affect goldens
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix UIWindowSceneGeometryPreferencesIOS leak
3 participants
@jmagman @cyanglaz @hellohuanlin