This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Change v2 mac_android_aot_engine orchestrator builder to Linux
#41181
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmagman
changed the title
keyonghan
reviewed
Apr 14, 2023
There was a problem hiding this comment.
Do we know how many subbuilds these two tasks trigger? We have only 5 intel bots in staging pool: https://chromium-swarm.appspot.com/botlist?c=id&c=task&c=os&c=status&d=asc&f=pool%3Aluci.flutter.staging&f=os%3AMac-12&k=gpu&s=id
Many. Examples: https://ci.chromium.org/p/flutter/builders/prod/Mac%20mac_android_aot_engine/2610 Would you mind running these with led to try them out since you were just attempting something similar with https://luci-milo.appspot.com/raw/build/logs.chromium.org/flutter/led/keyonghan_google.com/bb09df4c4ee5ab402e99a228902ba9675a9c79017b919c81b11538ea801ffc59/+/build.proto ? |
jmagman
changed the title
|
Starting with just |
|
That led run passed, let's do it. @keyonghan can I get a LGTM and we can try it? |
jmagman
added
the
autosubmit
jmagman
changed the title
mac_android_aot_engine orchestrator builder to Linux
auto-submit
bot
removed
the
autosubmit
|
auto label is removed for flutter/engine, pr: 41181, due to - The status or check suite Linux linux_web_engine has failed. Please fix the issues identified (or deflake) before re-applying this label. |
zanderso
approved these changes
Apr 14, 2023
jmagman
added
the
autosubmit
auto-submit bot
pushed a commit
that referenced
this pull request
Apr 14, 2023
`Linux mac_android_aot_engine` is passing: https://ci.chromium.org/p/flutter/builders/try/Linux%20mac_android_aot_engine/1 Remove `bringup` and remove `Mac mac_android_aot_engine` in favor of the Linux orchestrator #41181
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 14, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Apr 14, 2023
…124886) flutter/engine@87fc464...9c31406 2023-04-14 [email protected] Run the Mac impeller-cmake-example orchestrator on arm64 (flutter/engine#41194) 2023-04-14 [email protected] Fix warning about angle_build_all being unread on Mac builds. (flutter/engine#41176) 2023-04-14 [email protected] Change v2 `mac_android_aot_engine` orchestrator builder to Linux (flutter/engine#41181) 2023-04-14 [email protected] Do not run mac unit tests on macmini7,1 (flutter/engine#41203) 2023-04-14 [email protected] Manual roll Skia from ad2e21650306 to 2bd12e31d578 (14 revisions) (flutter/engine#41206) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
auto-submit bot
pushed a commit
that referenced
this pull request
Apr 14, 2023
`mac_unopt` orchestrator kicks off Mac swarming tasks, but don't seem to need to run on a Mac. Swap Linux bots which are more plentiful and have a shorter queue time. Start by adding new `bringup` builder to see if it passes in staging. If it passes I will remove the Mac variant ASAP. Led run: https://luci-milo.appspot.com/raw/build/logs.chromium.org/flutter/led/keyonghan_google.com/49f579a1636ddec2ffc05cb6053196a4472f5e4f69034386f88824356c479621/+/build.proto Keep `mac_ios_engine` and `mac_host_engine` as Macs since they need to run Xcodes on Macs to create the xcframeworks. See also #41181 and #41210
exaby73
pushed a commit
to exaby73/flutter_nevercode
that referenced
this pull request
Apr 17, 2023
…lutter#124886) flutter/engine@87fc464...9c31406 2023-04-14 [email protected] Run the Mac impeller-cmake-example orchestrator on arm64 (flutter/engine#41194) 2023-04-14 [email protected] Fix warning about angle_build_all being unread on Mac builds. (flutter/engine#41176) 2023-04-14 [email protected] Change v2 `mac_android_aot_engine` orchestrator builder to Linux (flutter/engine#41181) 2023-04-14 [email protected] Do not run mac unit tests on macmini7,1 (flutter/engine#41203) 2023-04-14 [email protected] Manual roll Skia from ad2e21650306 to 2bd12e31d578 (14 revisions) (flutter/engine#41206) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
itsjustkevin
pushed a commit
to itsjustkevin/engine
that referenced
this pull request
Apr 25, 2023
`Linux mac_android_aot_engine` is passing: https://ci.chromium.org/p/flutter/builders/try/Linux%20mac_android_aot_engine/1 Remove `bringup` and remove `Mac mac_android_aot_engine` in favor of the Linux orchestrator flutter#41181
drewroengoogle
pushed a commit
that referenced
this pull request
Jul 25, 2023
`mac_unopt` orchestrator kicks off Mac swarming tasks, but don't seem to need to run on a Mac. Swap Linux bots which are more plentiful and have a shorter queue time. Start by adding new `bringup` builder to see if it passes in staging. If it passes I will remove the Mac variant ASAP. Led run: https://luci-milo.appspot.com/raw/build/logs.chromium.org/flutter/led/keyonghan_google.com/49f579a1636ddec2ffc05cb6053196a4472f5e4f69034386f88824356c479621/+/build.proto Keep `mac_ios_engine` and `mac_host_engine` as Macs since they need to run Xcodes on Macs to create the xcframeworks. See also #41181 and #41210
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mac_android_aot_engineorchestrator kicks off Mac swarming tasks, but don't seem to need to run on a Mac. Swap Linux bots which are more plentiful and have a shorter queue time.Start by adding new
bringupbuilder to see if it passes in staging. If it passes I will remove the Mac variants ASAP.Keep
mac_ios_engineandmac_host_engineas Macs since they need to run Xcodes on Macs to create the xcframeworks.