This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Made sure not to turn on wide gamut support without impeller. #41460
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnfield
reviewed
Apr 24, 2023
| @@ -1402,6 +1402,10 @@ - (FlutterDartProject*)project { | |||
| return _dartProject.get(); | |||
| } | |||
|
|
|||
| - (BOOL)isUsingImpeller { | |||
| return self.project.isImpellerEnabled; | |||
There was a problem hiding this comment.
This is available via the shell, but there's nothing inherently wrong with exposing it on the project either.
dnfield
reviewed
Apr 25, 2023
| // This predicates the decision on the capabilities of the iOS device's | ||
| // display. This means external displays will not support wide gamut if the | ||
| // device's display doesn't support it. It practice that should be never. | ||
| return UIScreen.mainScreen.traitCollection.displayGamut != UIDisplayGamutSRGB; |
There was a problem hiding this comment.
nit: This should be using availability checks and then checking the UIScene API on newer iOS and falling back to this deprecated property. That would also solve the problem of not knowing whether a connected display is wide gamut or not.
There was a problem hiding this comment.
Filed issue: flutter/flutter#125496
There was a problem hiding this comment.
Can you instead use self.window.windowScene.screen.traitCollection.displayGamut? See mainScreenIfViewLoaded in the FlutterViewController for a fallback example.
engine/shell/platform/darwin/ios/framework/Source/FlutterViewController.mm
Lines 615 to 623 in 36730dd
dnfield
approved these changes
Apr 25, 2023
gaaclarke
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 25, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 26, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Apr 26, 2023
…125529) flutter/engine@34ece7a...b3cbf06 2023-04-25 [email protected] Migrate windows host engine to engine v2. (flutter/engine#41487) 2023-04-25 [email protected] Roll Skia from f6f0c4b5ee98 to 809bf518d4ab (3 revisions) (flutter/engine#41494) 2023-04-25 [email protected] Made sure not to turn on wide gamut support without impeller. (flutter/engine#41460) 2023-04-25 [email protected] Roll Fuchsia Mac SDK from 5bc9_eyVcLoMrWvdO... to JKHSUjf-qEr0ZMdEi... (flutter/engine#41493) 2023-04-25 [email protected] Roll Skia from 1bed4228ea3b to f6f0c4b5ee98 (7 revisions) (flutter/engine#41492) 2023-04-25 [email protected] [Impeller] Fixed blit command missing tracking and added mock vulkan for tests (flutter/engine#41408) Also rolling transitive DEPS: fuchsia/sdk/core/mac-amd64 from 5bc9_eyVcLoM to JKHSUjf-qEr0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes flutter/flutter#125430
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.