This repository was archived by the owner on Feb 25, 2025. It is now read-only.
reland "Migrate mac_host_engine to engine v2 builds." #41531
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit f6e64a8.
zanderso
approved these changes
Apr 27, 2023
godofredoc
added
the
autosubmit
auto-submit
bot
deleted the
revert-41233-revert-41149-migrate_host_engine
branch
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 27, 2023
godofredoc
pushed a commit
to flutter/flutter
that referenced
this pull request
Apr 27, 2023
…125598) flutter/engine@19045bb...689eb6e 2023-04-27 [email protected] reland "Migrate mac_host_engine to engine v2 builds." (flutter/engine#41531) 2023-04-27 [email protected] Roll buildroot to 5708f2051772fd02c949e5dc9397e54f8c7a4478 (flutter/engine#41540) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
|
@godofredoc @zanderso This PR along with d8e86b5 seems to have caused Apple to reject MacOS builds as outlined in flutter/flutter#126705 Are there any official workarounds or some migration steps that need to be taken in order for the build to get accepted? |
|
@borjandev Does this reproduce with a newer commit? |
|
@godofredoc Yes, every single commit after master flutter/flutter@3d25049 gets rejected with the same ITMS-90238: Invalid Signature issue Last good commit that gets properly accepted is Took me quite a lot of compiles and submissions to isolate the commit |
|
Let's continue the discussion in the bug |
2 tasks
2 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relands: #41149
GN+Ninja artifacts have been validated manually. The number of files and their content is the same and presubmit tests are passing correctly in the engine and flutter.
The reason of previous reverts are:
Full details of what has been fixed can be found in: flutter/flutter#124911