Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Use moved SkImage procs #41947

Merged
merged 1 commit into from
May 11, 2023
Merged

Use moved SkImage procs #41947

merged 1 commit into from
May 11, 2023

Conversation

kjlubick
Copy link
Contributor

Use relocated SkImages context typedefs

In http://review.skia.org/661059, we moved many SkImage related methods, including these typedefs. This updates Flutter to use the moved types.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added the embedder Related to the embedder API label May 11, 2023
@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@chinmaygarde chinmaygarde added the autosubmit Merge PR when tree becomes green via auto submit App label May 11, 2023
@auto-submit auto-submit bot merged commit 6e7dc9b into flutter:main May 11, 2023
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 11, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 11, 2023
@engine-flutter-autoroll
6e7dc9baa Use moved SkImage procs (flutter/engine#41947)
c08f3f6
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 11, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 11, 2023
@engine-flutter-autoroll
6e7dc9baa Use moved SkImage procs (flutter/engine#41947)
9aead35
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 11, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 11, 2023
@engine-flutter-autoroll
6e7dc9baa Use moved SkImage procs (flutter/engine#41947)
05f3214
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 12, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 12, 2023
@engine-flutter-autoroll
6e7dc9baa Use moved SkImage procs (flutter/engine#41947)
919e16d
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request May 12, 2023
@engine-flutter-autoroll
Roll Flutter Engine from f38f46f66e9a to 748ef964b993 (13 revisions) (#…
43b2b65 
…126622)

flutter/engine@f38f46f...748ef96

2023-05-11 [email protected] Roll Skia from aed81125e6bc to ccec5093ca38 (10 revisions) (flutter/engine#41963)
2023-05-11 [email protected] Roll Fuchsia Mac SDK from 2tQjI0g3aDmjHAtMw... to MjcKzcsqMDkuRKopu... (flutter/engine#41960)
2023-05-11 [email protected] iPhone floating cursor selection (flutter/engine#36643)
2023-05-11 [email protected] Update README.md (flutter/engine#41953)
2023-05-11 [email protected] Roll Clang from 5344d8e10bb7 to 6d667d4b261e (flutter/engine#41949)
2023-05-11 [email protected] Use moved SkImage procs (flutter/engine#41947)
2023-05-11 [email protected] allow supplying custom gn args in gn wrapper (flutter/engine#41794)
2023-05-11 [email protected] fix: platform_dispatcher documentation typo (flutter/engine#41739)
2023-05-11 [email protected] Remove GN staging flag for save layer bounds (flutter/engine#41940)
2023-05-11 [email protected] switch MockTexture off of MockCanvas calls (flutter/engine#41906)
2023-05-11 [email protected] [Android] Lifecycle defaults to focused instead of unfocused (flutter/engine#41875)
2023-05-11 [email protected] Roll Skia from ccf73af6ca91 to aed81125e6bc (9 revisions) (flutter/engine#41946)
2023-05-11 [email protected] Clobber caches in licenses test. (flutter/engine#41942)

Also rolling transitive DEPS:
  fuchsia/sdk/core/mac-amd64 from 2tQjI0g3aDmj to MjcKzcsqMDku

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
CaseyHillers pushed a commit to CaseyHillers/flutter that referenced this pull request May 24, 2023
@engine-flutter-autoroll
Roll Flutter Engine from f38f46f66e9a to 748ef964b993 (13 revisions) (f…
a1c1a24 
…lutter#126622)

flutter/engine@f38f46f...748ef96

2023-05-11 [email protected] Roll Skia from aed81125e6bc to ccec5093ca38 (10 revisions) (flutter/engine#41963)
2023-05-11 [email protected] Roll Fuchsia Mac SDK from 2tQjI0g3aDmjHAtMw... to MjcKzcsqMDkuRKopu... (flutter/engine#41960)
2023-05-11 [email protected] iPhone floating cursor selection (flutter/engine#36643)
2023-05-11 [email protected] Update README.md (flutter/engine#41953)
2023-05-11 [email protected] Roll Clang from 5344d8e10bb7 to 6d667d4b261e (flutter/engine#41949)
2023-05-11 [email protected] Use moved SkImage procs (flutter/engine#41947)
2023-05-11 [email protected] allow supplying custom gn args in gn wrapper (flutter/engine#41794)
2023-05-11 [email protected] fix: platform_dispatcher documentation typo (flutter/engine#41739)
2023-05-11 [email protected] Remove GN staging flag for save layer bounds (flutter/engine#41940)
2023-05-11 [email protected] switch MockTexture off of MockCanvas calls (flutter/engine#41906)
2023-05-11 [email protected] [Android] Lifecycle defaults to focused instead of unfocused (flutter/engine#41875)
2023-05-11 [email protected] Roll Skia from ccf73af6ca91 to aed81125e6bc (9 revisions) (flutter/engine#41946)
2023-05-11 [email protected] Clobber caches in licenses test. (flutter/engine#41942)

Also rolling transitive DEPS:
  fuchsia/sdk/core/mac-amd64 from 2tQjI0g3aDmj to MjcKzcsqMDku

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@kjlubick kjlubick deleted the image-move branch August 3, 2023 18:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@chinmaygarde chinmaygarde chinmaygarde approved these changes

@jason-simmons jason-simmons jason-simmons approved these changes

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App embedder Related to the embedder API needs tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kjlubick @chinmaygarde @jason-simmons