This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Impeller] Fix DrawPaint advanced blends on iOS. #42032
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change). If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 15, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 15, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
May 15, 2023
…126819) flutter/engine@d685520...7bd7482 2023-05-15 [email protected] Roll Dart SDK from 7d6324d5488b to c777d54743e1 (1 revision) (flutter/engine#42038) 2023-05-15 [email protected] [Impeller] Fix DrawPaint advanced blends on iOS. (flutter/engine#42032) 2023-05-15 49699333+dependabot[bot]@users.noreply.github.com Bump google/mirror-branch-action from 1.0 to 2.0 (flutter/engine#42037) 2023-05-15 [email protected] Roll Skia from 0c2083a60b66 to 4becb53e3c21 (2 revisions) (flutter/engine#42036) 2023-05-15 [email protected] Roll Fuchsia Linux SDK from jXrn0SP_MnSmhkz_P... to EweLgJoiYUDok2vyU... (flutter/engine#42035) 2023-05-15 [email protected] Roll Skia from 0410e5d9ec03 to 0c2083a60b66 (1 revision) (flutter/engine#42034) 2023-05-15 [email protected] [Impeller] Include AndroidSurfaceVulkanImpeller behind a flag (flutter/engine#42033) 2023-05-15 [email protected] Reland "Remove GN staging flag for save layer bounds" (flutter/engine#42029) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from jXrn0SP_MnSm to EweLgJoiYUDo If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
CaseyHillers
pushed a commit
to CaseyHillers/flutter
that referenced
this pull request
May 24, 2023
…lutter#126819) flutter/engine@d685520...7bd7482 2023-05-15 [email protected] Roll Dart SDK from 7d6324d5488b to c777d54743e1 (1 revision) (flutter/engine#42038) 2023-05-15 [email protected] [Impeller] Fix DrawPaint advanced blends on iOS. (flutter/engine#42032) 2023-05-15 49699333+dependabot[bot]@users.noreply.github.com Bump google/mirror-branch-action from 1.0 to 2.0 (flutter/engine#42037) 2023-05-15 [email protected] Roll Skia from 0c2083a60b66 to 4becb53e3c21 (2 revisions) (flutter/engine#42036) 2023-05-15 [email protected] Roll Fuchsia Linux SDK from jXrn0SP_MnSmhkz_P... to EweLgJoiYUDok2vyU... (flutter/engine#42035) 2023-05-15 [email protected] Roll Skia from 0410e5d9ec03 to 0c2083a60b66 (1 revision) (flutter/engine#42034) 2023-05-15 [email protected] [Impeller] Include AndroidSurfaceVulkanImpeller behind a flag (flutter/engine#42033) 2023-05-15 [email protected] Reland "Remove GN staging flag for save layer bounds" (flutter/engine#42029) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from jXrn0SP_MnSm to EweLgJoiYUDo If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves flutter/flutter#126790.
Adds an optional coverage limit when taking a snapshot contents, used by FramebufferBlendContents.
Also makes advanced blends more efficient in cases where blended object lies partially outside the pass.
Before:
Screen.Recording.2023-05-14.at.8.06.38.PM.mov
After:
Screen.Recording.2023-05-14.at.8.04.12.PM.mov