This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Fix the false failure caused by FlutterClippingMaskViewPool's random algorithm #42079
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hellohuanlin
approved these changes
May 17, 2023
shell/platform/darwin/ios/framework/Source/FlutterPlatformViewsTest.mm
Outdated
Show resolved
Hide resolved
hellohuanlin
approved these changes
May 17, 2023
cyanglaz
approved these changes
May 17, 2023
There was a problem hiding this comment.
LGTM! Thanks for fixing this. I think @hellohuanlin's suggestion is a good one to add before landing this!
shell/platform/darwin/ios/framework/Source/FlutterPlatformViewsTest.mm
Outdated
Show resolved
Hide resolved
shell/platform/darwin/ios/framework/Source/FlutterPlatformViewsTest.mm
Outdated
Show resolved
Hide resolved
Merged
8 tasks
|
@dkwingsmt I'm planning to cherry pick the maskview pool commit when it lands. Re-land PR: #42115 (review) |
|
@cyanglaz Yeah sure! |
|
Feel free to close this PR after you've merged this one into yours. |
|
The linked PRs description says "This needs to be landed after #42079". Does this still need to be landed? |
|
@chinmaygarde Nope. I've closed this one. But #42115 needs to be merged with this PR before merging. |
auto-submit bot
pushed a commit
that referenced
this pull request
May 22, 2023
…plying mutators #41573" (#42115) The original PR (#41573) was reverted due to flutter/flutter#126951 The issue will be fixed in #42079 This needs to be landed after #42079 fixes: flutter/flutter#125620 [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes flutter/flutter#126951
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.