Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Revert Dart SDK to 3.1.0-163.0.dev for branch alignment #42569

Merged
merged 2 commits into from
Jun 5, 2023

Conversation

zanderso
Copy link
Member

@zanderso zanderso commented Jun 5, 2023

3.1.0-163.0.dev is the most recent version in g3 that has successfully rolled to the framework. This PR rolls the engine back to this last known good version of Dart.

@zanderso zanderso requested review from aam, dnfield and jonahwilliams June 5, 2023 15:36
@zanderso
Copy link
Member Author

zanderso commented Jun 5, 2023

The third party license hash will likely need to be updated.

@zanderso zanderso force-pushed the revert-dart-for-alignment branch from 6064e29 to 2662dad Compare June 5, 2023 15:51
Copy link
Member

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zanderso zanderso merged commit bfcf877 into flutter:main Jun 5, 2023
@zanderso zanderso deleted the revert-dart-for-alignment branch June 5, 2023 16:34
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 5, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 5, 2023
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Jun 5, 2023
…128271)

flutter/engine@f9f7238...7f12e34

2023-06-05 [email protected] Fix clang tidy error and crash (flutter/engine#42564)
2023-06-05 [email protected] Roll Fuchsia Linux SDK from gp1k1agqxQIz0oTXV... to vAwdggqMrL1yoH_Zn... (flutter/engine#42570)
2023-06-05 [email protected] Revert Dart SDK to 3.1.0-163.0.dev for branch alignment (flutter/engine#42569)
2023-06-05 [email protected] Check more optional accesses (flutter/engine#42528)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from gp1k1agqxQIz to vAwdggqMrL1y

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants