Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Ensure Dart roll script picks up udpates to dart-sdk/tools #42576

Merged
merged 1 commit into from
Jun 5, 2023

Conversation

zanderso
Copy link
Member

@zanderso zanderso commented Jun 5, 2023

The build of the Dart SDK depends on this package, so it needs to be kept up to date by https://github.com/flutter/buildroot/blob/master/tools/dart/create_updated_flutter_deps.py, which is run by the autoroller.

@zanderso zanderso requested a review from jason-simmons June 5, 2023 19:26
@zanderso
Copy link
Member Author

zanderso commented Jun 5, 2023

The absence of autorolling this package is one of the causes of flutter/flutter#127606.

@zanderso zanderso requested a review from aam June 5, 2023 19:37
@zanderso zanderso merged commit 220ece4 into flutter:main Jun 5, 2023
@zanderso zanderso deleted the add-dart-tools branch June 5, 2023 20:48
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Jun 5, 2023
…128282)

flutter/engine@7f12e34...220ece4

2023-06-05 [email protected] Ensure Dart roll script picks up udpates to dart-sdk/tools (flutter/engine#42576)
2023-06-05 [email protected] Run dependabot in off peak hours (flutter/engine#42572)
2023-06-05 [email protected] fix bounds of inverted rendered rectangles (flutter/engine#42556)
2023-06-05 [email protected] Roll Fuchsia Mac SDK from fgfgAhpxFpse7Xi4i... to tCxDcZ3yi0rnKGVHt... (flutter/engine#42574)
2023-06-05 [email protected] Add missing #include of SkCFObject.h (flutter/engine#42573)
2023-06-05 [email protected] Improve getting non-overlapping rectangles from RTree (flutter/engine#42399)

Also rolling transitive DEPS:
  fuchsia/sdk/core/mac-amd64 from fgfgAhpxFpse to tCxDcZ3yi0rn

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants