This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Impeller] Corrected the 'texture_coords' computation in 'Geometry::GetPositionUVBuffer' #42619
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…etPositionUVBuffer'
|
Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change). If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review. |
jonahwilliams
approved these changes
Jun 7, 2023
ColdPaleLight
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 7, 2023
…eometry::GetPositionUVBuffer' (flutter/engine#42619)
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jun 7, 2023
…128473) flutter/engine@1089ce6...a5f7d5d 2023-06-07 [email protected] Roll Skia from c5a8c4547f59 to 156542f8bf13 (4 revisions) (flutter/engine#42641) 2023-06-07 [email protected] Roll HarfBuzz to 7.3.0 (flutter/engine#42629) 2023-06-07 [email protected] [Impeller] Corrected the 'texture_coords' computation in 'Geometry::GetPositionUVBuffer' (flutter/engine#42619) 2023-06-07 [email protected] Roll dart to 3.1.0-171.0.dev (flutter/engine#42636) 2023-06-07 [email protected] Roll Skia from 773765ca1dd2 to c5a8c4547f59 (4 revisions) (flutter/engine#42633) 2023-06-07 [email protected] Add global test docs. (flutter/engine#42531) 2023-06-07 [email protected] Roll Fuchsia Mac SDK from ojwVlxZWrbsG4WGSE... to DL1QQ5eZRVNARqLx-... (flutter/engine#42632) 2023-06-07 [email protected] Roll Fuchsia Linux SDK from sEHtHM1iFt79roP-x... to aMTaMP0DdKdJnxSbc... (flutter/engine#42631) 2023-06-07 [email protected] [labeler] Fix to run on flutter/engine (flutter/engine#42634) 2023-06-07 [email protected] [iOS] Fix TextInputAction.continueAction sends wrong action to framework (flutter/engine#42615) 2023-06-07 [email protected] [Impeller] fix missing assignment of embedder render target. (flutter/engine#42630) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from sEHtHM1iFt79 to aMTaMP0DdKdJ fuchsia/sdk/core/mac-amd64 from ojwVlxZWrbsG to DL1QQ5eZRVNA If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix flutter/flutter#128328
We need to transform the 'position' first and then divide 'texture_coverage', otherwise the result will be incorrect.
without patch
with patch
Pre-launch Checklist
///).