[Impeller] added debug info to frame debuggers like AGI #42717
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change). If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review. |
…128721) flutter/engine@33e0693...de68fba 2023-06-12 [email protected] Fix crash with CJK keyboard with emoji at end of text field (flutter/engine#42540) 2023-06-12 [email protected] Roll Skia from 658b1d366758 to 6bdb0ef30cb6 (2 revisions) (flutter/engine#42778) 2023-06-12 [email protected] [Impeller] Correct attachment description for offscreen MSAA resolve. (flutter/engine#42753) 2023-06-12 [email protected] Remove dependency on memfs (flutter/engine#42773) 2023-06-12 [email protected] Roll Skia from 0f974a0f8c10 to 658b1d366758 (1 revision) (flutter/engine#42776) 2023-06-12 [email protected] Roll ANGLE from 3abbc4f99970 to 43ef50f389e9 (1 revision) (flutter/engine#42775) 2023-06-12 [email protected] Remove unnecessary #include of SkPromiseImageTexture (flutter/engine#42770) 2023-06-12 [email protected] Roll Skia from 951123096e55 to 0f974a0f8c10 (5 revisions) (flutter/engine#42771) 2023-06-12 [email protected] [Impeller] opt all vertex shader position/uvs into highp (flutter/engine#42746) 2023-06-12 [email protected] [Impeller] added debug info to frame debuggers like AGI (flutter/engine#42717) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
fixes flutter/flutter#128629
Screenshot of the change in action:
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.