Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Fix generateLockfiles running directory for documentation #42734

Merged
merged 1 commit into from
Jun 14, 2023
Merged

Fix generateLockfiles running directory for documentation #42734

merged 1 commit into from
Jun 14, 2023

Conversation

utzcoz
Copy link
Contributor

@utzcoz utzcoz commented Jun 11, 2023

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

@utzcoz
Copy link
Contributor Author

utzcoz commented Jun 11, 2023

The generateLockfiles task is defined in scenario_app/android/app/build.gradle.

cc @dnfield @zanderso for reviewing.

@utzcoz utzcoz force-pushed the generateLockfiles-dir branch from 99eebac to 01df1f7 Compare June 11, 2023 06:46
@utzcoz utzcoz force-pushed the generateLockfiles-dir branch from 01df1f7 to cfad784 Compare June 11, 2023 15:41
dnfield
dnfield reviewed Jun 12, 2023
View reviewed changes
Copy link
Contributor

@dnfield dnfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gradle knows how to find this task from the directory specified right

@utzcoz
Copy link
Contributor Author

utzcoz commented Jun 13, 2023

@dnfield Thanks for your reviewing. Yep, the Gradle can find generateLockfiles task in the directory contains build.gradle. But we need to add extra --write-locks to update generated gradle.lock. The generateLockfiles defined in android/app directory adds this command for all submodule that contains build.gradle, so it looks like more convinent to update Gradle generated lock files.

@dnfield dnfield added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 13, 2023
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jun 13, 2023
@auto-submit
Copy link
Contributor

auto-submit bot commented Jun 13, 2023

auto label is removed for flutter/engine, pr: 42734, due to This PR has not met approval requirements for merging. You are not a member of flutter-hackers and need 1 more review(s) in order to merge this PR.

  • Merge guidelines: You need at least one approved review if you are already part of flutter-hackers or two member reviews if you are not a flutter-hacker before re-applying the autosubmit label. Reviewers: If you left a comment approving, please use the "approve" review action instead.

@utzcoz
Copy link
Contributor Author

utzcoz commented Jun 14, 2023

Hi @zanderso, could you help to give an extra reviewing for this PR? Looks like my PR needs at least two people's approvaling.

@jason-simmons jason-simmons added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 14, 2023
@auto-submit auto-submit bot merged commit c0964f5 into flutter:main Jun 14, 2023
@utzcoz utzcoz deleted the generateLockfiles-dir branch June 14, 2023 15:13
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 15, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 15, 2023
@engine-flutter-autoroll
c0964f5d0 Fix generateLockfiles running directory for documentation (f…
578380e 
…lutter/engine#42734)
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Jun 15, 2023
@engine-flutter-autoroll
Roll Flutter Engine from 9934c0de738c to 48e0b4e66422 (26 revisions) (#…
c716776 
…128959)

flutter/engine@9934c0d...48e0b4e

2023-06-15 [email protected] Roll Skia from 0b66c6928dcf to 2d531d020c26 (3 revisions) (flutter/engine#42883)
2023-06-15 [email protected] Raster cache should preserve RTree for overlay layers (flutter/engine#42552)
2023-06-15 [email protected] Roll Skia from c0c74b433117 to 0b66c6928dcf (1 revision) (flutter/engine#42879)
2023-06-15 [email protected] [Linux] Allow BasicMessageChannel sending and responding to null message (flutter/engine#42808)
2023-06-15 [email protected] Roll Skia from 12375fb6f3c8 to c0c74b433117 (1 revision) (flutter/engine#42876)
2023-06-15 [email protected] Roll Skia from d62221bd33a6 to 12375fb6f3c8 (1 revision) (flutter/engine#42873)
2023-06-15 [email protected] Roll Skia from e2e0256d4c6a to d62221bd33a6 (1 revision) (flutter/engine#42871)
2023-06-15 [email protected] Roll Skia from c3abd540c7f9 to e2e0256d4c6a (1 revision) (flutter/engine#42869)
2023-06-15 [email protected] Roll Fuchsia Linux SDK from uvmDF7KM34dWGdsuK... to 53EjCyuRu91oFTBf2... (flutter/engine#42868)
2023-06-15 [email protected] Roll Fuchsia Mac SDK from h3-8RUVrC889UXou7... to P7QA6bfO_Ij5dre7B... (flutter/engine#42867)
2023-06-15 [email protected] Roll Skia from 2718866006d2 to c3abd540c7f9 (1 revision) (flutter/engine#42866)
2023-06-15 [email protected] Roll Skia from 19051bc5fc90 to 2718866006d2 (33 revisions) (flutter/engine#42864)
2023-06-15 [email protected] Roll Dart SDK from 922c315b2c34 to 8eaed3382237 (1 revision) (flutter/engine#42862)
2023-06-15 [email protected] Add missing artifact to the android_arm64_profile config. (flutter/engine#42858)
2023-06-14 [email protected] Build skia with expat (flutter/engine#42859)
2023-06-14 [email protected] [ios] use interfaceOrientation orientation on iOS 13 and above (flutter/engine#42846)
2023-06-14 [email protected] Manual roll Dart SDK from f1387834bfd9 to 922c315b2c34 (4 revisions) (flutter/engine#42855)
2023-06-14 [email protected] [Impeller] Make interleaved layout (more) explicit in generated headers. (flutter/engine#42628)
2023-06-14 [email protected] Renamed validation layers build (flutter/engine#42826)
2023-06-14 [email protected] [ios] view controller based status bar (flutter/engine#42643)
2023-06-14 [email protected] Roll Skia from 6d5dc31d88e2 to 19051bc5fc90 (25 revisions) (flutter/engine#42828)
2023-06-14 [email protected] Roll Fuchsia Linux SDK from Xi3c5nti2LKnEOqYt... to uvmDF7KM34dWGdsuK... (flutter/engine#42842)
2023-06-14 [email protected] Fix generateLockfiles running directory for documentation (flutter/engine#42734)
2023-06-14 [email protected] Roll Fuchsia Mac SDK from Cld7-rm6ZmCOO8j-K... to h3-8RUVrC889UXou7... (flutter/engine#42839)
2023-06-14 [email protected] Roll ANGLE from 7e075469ff02 to 3a3a3c655a96 (8 revisions) (flutter/engine#42834)
2023-06-14 [email protected] Roll Dart SDK from c4e9794df8af to f1387834bfd9 (1 revision) (flutter/engine#42833)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from Xi3c5nti2LKn to 53EjCyuRu91o
  fuchsia/sdk/core/mac-amd64 from Cld7-rm6ZmCO to P7QA6bfO_Ij5

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dnfield dnfield dnfield approved these changes

@jason-simmons jason-simmons jason-simmons approved these changes

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@utzcoz @dnfield @jason-simmons