Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[Impeller] Fix text jitter on Vulkan. #42792

Merged
merged 3 commits into from
Jun 12, 2023

Conversation

jonahwilliams
Copy link
Member

Copy link
Member

@gaaclarke gaaclarke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hopefully this shows up in the swiftshader tests. I'm not sure of another easy way to test that we don't break this.

@jonahwilliams
Copy link
Member Author

It probably wont. Vulkan Relaxed precision can be ignored by backends, and I'd expect anything CPU backed to ignore relaxed precision since they won't actually have 16bit registers.

@jonahwilliams jonahwilliams added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 12, 2023
@auto-submit auto-submit bot merged commit d02b15e into flutter:main Jun 12, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 13, 2023
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Jun 13, 2023
…128754)

flutter/engine@f67ed35...d02b15e

2023-06-12 [email protected] [Impeller] Fix text jitter on Vulkan. (flutter/engine#42792)
2023-06-12 [email protected] Predictive back breakage fix (flutter/engine#42789)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
autosubmit Merge PR when tree becomes green via auto submit App e: impeller
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[Impeller] Vulkan: Top line of text is cropped sometimes in wonderous app
2 participants