This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[fuchsia] Remove strict equality check for SkMatrix comparison for Fl… #43309
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
arbreng
approved these changes
Jun 29, 2023
shell/platform/fuchsia/flutter/flatland_external_view_embedder.cc
Outdated
Show resolved
Hide resolved
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 29, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jun 29, 2023
flutter/engine@cd9ce66...68cc1a7 2023-06-29 [email protected] Roll Skia from a4d0373cd414 to c83f8ba23a80 (3 revisions) (flutter/engine#43340) 2023-06-29 [email protected] [web] Move web-only initialization APIs to `dart:ui_web` (flutter/engine#43111) 2023-06-29 [email protected] Roll Skia from 8ada2c4b2947 to a4d0373cd414 (14 revisions) (flutter/engine#43338) 2023-06-29 [email protected] Roll Dart SDK from 656201921b30 to ecc2440be198 (1 revision) (flutter/engine#43333) 2023-06-29 [email protected] Roll Skia from 0c320b3d5b64 to 8ada2c4b2947 (1 revision) (flutter/engine#43332) 2023-06-29 [email protected] Roll Fuchsia Linux SDK from fxCNy4QivAngZXkvM... to nboAFpQUzwtrESDVo... (flutter/engine#43334) 2023-06-29 [email protected] Prepare for utf8.encode() to return more precise Uint8List type (flutter/engine#43335) 2023-06-29 [email protected] [Impeller] Ensure that the auto-release pool is available when the GoldenPlaygroundTestImpl is destructed (flutter/engine#43322) 2023-06-29 [email protected] [fuchsia] Remove strict equality check for SkMatrix comparison for Fl� (flutter/engine#43309) 2023-06-29 [email protected] [Impeller] Add an autorelease pool to the GoldenTests fixture (flutter/engine#43323) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from fxCNy4QivAng to nboAFpQUzwtr If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
kjlubick
pushed a commit
to kjlubick/engine
that referenced
this pull request
Jul 14, 2023
flutter#43309) Flatland version of flutter@a4775c7 Bug: fxb/126648
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Flatland version of a4775c7
Bug: fxb/126648