This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Linux] Fix channel buffers control commands error handling #45056
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robert-ancell
suggested changes
Aug 25, 2023
robert-ancell
approved these changes
Sep 1, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 1, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 1, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 1, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 1, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Sep 1, 2023
…133857) flutter/engine@ced8f1a...4c085b8 2023-09-01 [email protected] Roll Fuchsia Mac SDK from _x3hf702RacYnw3E6... to sk7JBGzW1Jw10Wy-T... (flutter/engine#45372) 2023-09-01 [email protected] [Linux] Fix channel buffers control commands error handling (flutter/engine#45056) Also rolling transitive DEPS: fuchsia/sdk/core/mac-amd64 from _x3hf702RacY to sk7JBGzW1Jw1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a mistake I made on #44636 where the error handling code wrongly relied on
fl_method_channel_invoke_method_finishinstead offl_binary_messenger_send_on_channel_finish.The error handling code was not called when running the tests added in #44636 so this mistake did not pop up.
@robert-ancell I added a test that simulates an error response and I had to rely on
g_idle_addto make it works. Is this approach ok?Related Issue
Linux implementation for flutter/flutter#132386
Tests
Adds one test.