Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Revert "[Impeller] Fixes stroke path geometry that can draw outside o… #46334

Merged
merged 1 commit into from
Sep 27, 2023
Merged

Revert "[Impeller] Fixes stroke path geometry that can draw outside o… #46334

merged 1 commit into from
Sep 27, 2023

Conversation

chunhtai
Copy link
Contributor

…f path if the path ends at sharp turn. (#45252)"

This reverts commit 343dfe8.

introduced a regression
flutter/flutter#135225

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@chunhtai
Revert "[Impeller] Fixes stroke path geometry that can draw outside o…
5930fde 
…f path if the path ends at sharp turn. (flutter#45252)"

This reverts commit 343dfe8.
@chunhtai chunhtai mentioned this pull request Sep 27, 2023
Closed
2 tasks
jonahwilliams
jonahwilliams approved these changes Sep 27, 2023
View reviewed changes
Copy link
Member

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chunhtai chunhtai added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 27, 2023
@auto-submit auto-submit bot merged commit 1d15b35 into flutter:main Sep 27, 2023
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 28, 2023
Merged
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 28, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 28, 2023
@engine-flutter-autoroll
1d15b35d9 Revert "[Impeller] Fixes stroke path geometry that can draw…
08303bd 
… outside o… (flutter/engine#46334)
zanderso pushed a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 28, 2023
@engine-flutter-autoroll @zanderso
1d15b35d9 Revert "[Impeller] Fixes stroke path geometry that can draw…
9182ef6 
… outside o… (flutter/engine#46334)
zanderso pushed a commit to flutter/flutter that referenced this pull request Sep 28, 2023
@engine-flutter-autoroll
Manual roll Flutter Engine from f70f65f7a622 to be32dcc9117a (31 revi…
f2cf0cc 
…sions) (#135637)

Manual roll Flutter Engine from f70f65f7a622 to be32dcc9117a (31
revisions)

Manual roll requested by [email protected]

Cannot build log URL because revision "be32dcc9117a" is invalid: Luci
builds of "Linux linux_unopt" for
be32dcc9117a462760cb52c18d0d050f067f2463 was STARTED

2023-09-28 [email protected] Rollback Dart SDK to 3.2.0-119.
(flutter/engine#46339)
2023-09-28 [email protected] [canvaskit]
Do not double-apply ImageFilter transform to children
(flutter/engine#46336)
2023-09-28 [email protected] Reland "Reverts "[ios] Fix app extension
not able to find assets from… (flutter/engine#46329)
2023-09-27 [email protected] Revert "[Impeller]
Fixes stroke path geometry that can draw outside o…
(flutter/engine#46334)
2023-09-27 [email protected] Roll Fuchsia Mac SDK from
jQHACBU4Fi2wMElkm... to U334SygIkffMJVmdu... (flutter/engine#46333)
2023-09-27 [email protected] Roll Skia from 952e8dd66560 to
b048b468d641 (1 revision) (flutter/engine#46332)
2023-09-27 [email protected] [Impeller] Destroy all
per-thread command pools tied to a context before deleting the context
(flutter/engine#46286)
2023-09-27 [email protected] Roll Skia from d78aba2524b3 to
952e8dd66560 (1 revision) (flutter/engine#46331)
2023-09-27 [email protected] [Impeller] Match Skia gradient
clamping behavior (and document). (flutter/engine#44825)
2023-09-27 [email protected] Roll Dart SDK from
97647bb1666b to 80a965ee48ab (1 revision) (flutter/engine#46330)
2023-09-27 [email protected] Roll Skia from ff5474eed6b4 to
d78aba2524b3 (3 revisions) (flutter/engine#46327)
2023-09-27 98614782+auto-submit[bot]@users.noreply.github.com Reverts
"[ios] Fix app extension not able to find assets from unloaded bundle"
(flutter/engine#46328)
2023-09-27 [email protected] [Windows] Improve
logic to update swap intervals (flutter/engine#46172)
2023-09-27 [email protected] [Impeller] Fallback to no index
buffer when tesselation count is large, split up nonZero contours.
(flutter/engine#46282)
2023-09-27 [email protected] Roll Skia from 4731ccd6342c to
ff5474eed6b4 (1 revision) (flutter/engine#46325)
2023-09-27 [email protected] Declare native wrapper
classes in Fuchsia packages as base classes (flutter/engine#46305)
2023-09-27 [email protected] Remove fuchsia from recipes cq.
(flutter/engine#46324)
2023-09-27 [email protected] Roll Dart SDK from
c2a455113e39 to 97647bb1666b (1 revision) (flutter/engine#46323)
2023-09-27 [email protected] [macOS] Synchronise modifiers from
mouse events for RawKeyboard (flutter/engine#46230)
2023-09-27 [email protected] Roll Fuchsia Linux SDK from
Lg6FR6iDnZeV6y-E8... to 6Y22MutFhgL7ua18F... (flutter/engine#46322)
2023-09-27 [email protected] Roll Skia from 2991bb799d3f to
4731ccd6342c (1 revision) (flutter/engine#46321)
2023-09-27 [email protected] Declare native wrapper
classes in the GPU package as base classes (flutter/engine#46304)
2023-09-27 [email protected] Do not call
DrawTextBlob for performance overlay text when using Impeller
(flutter/engine#46307)
2023-09-27 [email protected] Update to use
GrDirectContexts::MakeGL (flutter/engine#46308)
2023-09-27 [email protected] Roll Skia from 0f4f31127ac5 to
2991bb799d3f (1 revision) (flutter/engine#46319)
2023-09-27 [email protected] Roll Skia from fc629215398f to
0f4f31127ac5 (1 revision) (flutter/engine#46318)
2023-09-27 [email protected] Roll Dart SDK from
6c4eb86ecd25 to c2a455113e39 (1 revision) (flutter/engine#46317)
2023-09-27 [email protected] Roll Fuchsia Mac SDK from
OMrTgAfDg9PKXTzq0... to jQHACBU4Fi2wMElkm... (flutter/engine#46314)
2023-09-27 [email protected] Roll Skia from 960325c13009 to
fc629215398f (1 revision) (flutter/engine#46313)
2023-09-27 [email protected] Roll Skia from 76aecbaea259 to
960325c13009 (2 revisions) (flutter/engine#46311)
2023-09-27 [email protected] Roll Dart SDK from
7c3588c05f87 to 6c4eb86ecd25 (3 revisions) (flutter/engine#46310)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from Lg6FR6iDnZeV to 6Y22MutFhgL7
  fuchsia/sdk/core/mac-amd64 from OMrTgAfDg9PK to U334SygIkffM

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on
the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

...
chunhtai added a commit to chunhtai/engine that referenced this pull request Sep 29, 2023
@chunhtai
Reapply "[Impeller] Fixes stroke path geometry that can draw outside …
d468d00 
…o… (flutter#46334)

This reverts commit 1d15b35.
Mairramer pushed a commit to Mairramer/flutter that referenced this pull request Oct 10, 2023
@engine-flutter-autoroll @Mairramer
Manual roll Flutter Engine from f70f65f7a622 to be32dcc9117a (31 revi…
730a17c 
…sions) (flutter#135637)

Manual roll Flutter Engine from f70f65f7a622 to be32dcc9117a (31
revisions)

Manual roll requested by [email protected]

Cannot build log URL because revision "be32dcc9117a" is invalid: Luci
builds of "Linux linux_unopt" for
be32dcc9117a462760cb52c18d0d050f067f2463 was STARTED

2023-09-28 [email protected] Rollback Dart SDK to 3.2.0-119.
(flutter/engine#46339)
2023-09-28 [email protected] [canvaskit]
Do not double-apply ImageFilter transform to children
(flutter/engine#46336)
2023-09-28 [email protected] Reland "Reverts "[ios] Fix app extension
not able to find assets from… (flutter/engine#46329)
2023-09-27 [email protected] Revert "[Impeller]
Fixes stroke path geometry that can draw outside o…
(flutter/engine#46334)
2023-09-27 [email protected] Roll Fuchsia Mac SDK from
jQHACBU4Fi2wMElkm... to U334SygIkffMJVmdu... (flutter/engine#46333)
2023-09-27 [email protected] Roll Skia from 952e8dd66560 to
b048b468d641 (1 revision) (flutter/engine#46332)
2023-09-27 [email protected] [Impeller] Destroy all
per-thread command pools tied to a context before deleting the context
(flutter/engine#46286)
2023-09-27 [email protected] Roll Skia from d78aba2524b3 to
952e8dd66560 (1 revision) (flutter/engine#46331)
2023-09-27 [email protected] [Impeller] Match Skia gradient
clamping behavior (and document). (flutter/engine#44825)
2023-09-27 [email protected] Roll Dart SDK from
97647bb1666b to 80a965ee48ab (1 revision) (flutter/engine#46330)
2023-09-27 [email protected] Roll Skia from ff5474eed6b4 to
d78aba2524b3 (3 revisions) (flutter/engine#46327)
2023-09-27 98614782+auto-submit[bot]@users.noreply.github.com Reverts
"[ios] Fix app extension not able to find assets from unloaded bundle"
(flutter/engine#46328)
2023-09-27 [email protected] [Windows] Improve
logic to update swap intervals (flutter/engine#46172)
2023-09-27 [email protected] [Impeller] Fallback to no index
buffer when tesselation count is large, split up nonZero contours.
(flutter/engine#46282)
2023-09-27 [email protected] Roll Skia from 4731ccd6342c to
ff5474eed6b4 (1 revision) (flutter/engine#46325)
2023-09-27 [email protected] Declare native wrapper
classes in Fuchsia packages as base classes (flutter/engine#46305)
2023-09-27 [email protected] Remove fuchsia from recipes cq.
(flutter/engine#46324)
2023-09-27 [email protected] Roll Dart SDK from
c2a455113e39 to 97647bb1666b (1 revision) (flutter/engine#46323)
2023-09-27 [email protected] [macOS] Synchronise modifiers from
mouse events for RawKeyboard (flutter/engine#46230)
2023-09-27 [email protected] Roll Fuchsia Linux SDK from
Lg6FR6iDnZeV6y-E8... to 6Y22MutFhgL7ua18F... (flutter/engine#46322)
2023-09-27 [email protected] Roll Skia from 2991bb799d3f to
4731ccd6342c (1 revision) (flutter/engine#46321)
2023-09-27 [email protected] Declare native wrapper
classes in the GPU package as base classes (flutter/engine#46304)
2023-09-27 [email protected] Do not call
DrawTextBlob for performance overlay text when using Impeller
(flutter/engine#46307)
2023-09-27 [email protected] Update to use
GrDirectContexts::MakeGL (flutter/engine#46308)
2023-09-27 [email protected] Roll Skia from 0f4f31127ac5 to
2991bb799d3f (1 revision) (flutter/engine#46319)
2023-09-27 [email protected] Roll Skia from fc629215398f to
0f4f31127ac5 (1 revision) (flutter/engine#46318)
2023-09-27 [email protected] Roll Dart SDK from
6c4eb86ecd25 to c2a455113e39 (1 revision) (flutter/engine#46317)
2023-09-27 [email protected] Roll Fuchsia Mac SDK from
OMrTgAfDg9PKXTzq0... to jQHACBU4Fi2wMElkm... (flutter/engine#46314)
2023-09-27 [email protected] Roll Skia from 960325c13009 to
fc629215398f (1 revision) (flutter/engine#46313)
2023-09-27 [email protected] Roll Skia from 76aecbaea259 to
960325c13009 (2 revisions) (flutter/engine#46311)
2023-09-27 [email protected] Roll Dart SDK from
7c3588c05f87 to 6c4eb86ecd25 (3 revisions) (flutter/engine#46310)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from Lg6FR6iDnZeV to 6Y22MutFhgL7
  fuchsia/sdk/core/mac-amd64 from OMrTgAfDg9PK to U334SygIkffM

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on
the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

...
chunhtai added a commit to chunhtai/engine that referenced this pull request Oct 18, 2023
@chunhtai
Reapply "[Impeller] Fixes stroke path geometry that can draw outside …
2584e1b 
…o… (flutter#46334)

This reverts commit 1d15b35.
harryterkelsen pushed a commit that referenced this pull request Oct 23, 2023
@chunhtai @harryterkelsen
Revert "[Impeller] Fixes stroke path geometry that can draw outside o… (
b5b138f 
#46334)

�f path if the path ends at sharp turn. (#45252)"

This reverts commit 343dfe8.

introduced a regression
flutter/flutter#135225

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
@lsaudon
Copy link

lsaudon commented Nov 16, 2023

This PR is not in Flutter 3.16 ?

@lsaudon
Copy link

lsaudon commented Jan 23, 2024

Any update for this PR push in stable version ?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jonahwilliams jonahwilliams jonahwilliams approved these changes

@bdero bdero Awaiting requested review from bdero

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App e: impeller
Projects
No open projects
Impeller
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chunhtai @lsaudon @jonahwilliams