This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[macOS] Fix tests failing on Sonoma #46461
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Btw, Chromium seems to have patched the OCMArg problem: https://chromium-review.googlesource.com/c/chromium/src/+/3011651 |
cbracken
approved these changes
Oct 18, 2023
cbracken
added
the
autosubmit
|
Thanks again for the fix; this is additional justification for us to find time to dig into the non-hermetic test situation in the macOS embedder tests so we can re-enable the presubmits. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 18, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 18, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Oct 18, 2023
…136789) flutter/engine@1de09d1...0c1c292 2023-10-18 [email protected] Roll Skia from 8796ee7d1c66 to 3d938d4b00ee (3 revisions) (flutter/engine#47042) 2023-10-18 [email protected] Roll Skia from 13694b8c64aa to 8796ee7d1c66 (1 revision) (flutter/engine#47041) 2023-10-18 [email protected] [macOS] Fix tests failing on Sonoma (flutter/engine#46461) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
harryterkelsen
pushed a commit
that referenced
this pull request
Oct 23, 2023
1. Using arbitrary struct passed as const reference to `OCMStub` now fails in OCMock. Down the line this will result with `object_getClass` being called in [`OCMArg.m`](https://github.com/erikdoe/ocmock/blob/master/Source/OCMock/OCMArg.m#L129-L133) with the address of the reference, which is not a valid class instance. This seems to have worked pre-sonoma, but it seems like a weird thing to rely on. 2. `NSResponder` mock can not be set to view controller anymore. The controller will try to access an ivar of the `NSResponder`, but mocked responder does not have the ivar of original objects which will result on invalid selector being called on a `NSMutableArray` one of the ivar of mock objects. Solution for this is to inherit from `NSResponder` and forward calls to mocked object. 3. Adding `flutter::kModifierFlagShiftLeft` to a modifier flag containing `kCGEventFlagMaskShift`. The assertion was introduced in #46230 but i missed the test failure because of the problems above. [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using arbitrary struct passed as const reference to
OCMStubnow fails in OCMock. Down the line this will result withobject_getClassbeing called inOCMArg.mwith the address of the reference, which is not a valid class instance. This seems to have worked pre-sonoma, but it seems like a weird thing to rely on.NSRespondermock can not be set to view controller anymore. The controller will try to access an ivar of theNSResponder, but mocked responder does not have the ivar of original objects which will result on invalid selector being called on aNSMutableArrayone of the ivar of mock objects. Solution for this is to inherit fromNSResponderand forward calls to mocked object.Adding
flutter::kModifierFlagShiftLeftto a modifier flag containingkCGEventFlagMaskShift. The assertion was introduced in [macOS] Synchronise modifiers from mouse events for RawKeyboard #46230 but i missed the test failure because of the problems above.Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.