[Impeller] Implement framebuffer fetch support for OpenGLES. #46585

jonahwilliams · 2023-10-05T13:39:40Z

flutter/flutter#120223 for OpenGLES. Checks for support of the framebuffer fetch extension: https://registry.khronos.org/OpenGL/extensions/EXT/EXT_shader_framebuffer_fetch.txt . This is supported on a Pixel 6 at least, we should double check the distribution of the extension.

flutter-dashboard · 2023-10-05T13:39:44Z

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie or stuartmorgan on the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

jonahwilliams · 2023-10-05T13:48:15Z

impeller/entity/contents/framebuffer_blend_contents.cc

@@ -133,11 +133,14 @@ bool FramebufferBlendContents::Render(const ContentContext& renderer,

  auto src_sampler_descriptor = src_snapshot->sampler_descriptor;
  if (!renderer.GetDeviceCapabilities().SupportsDecalSamplerAddressMode()) {
-    // No known devices that support framebuffer fetch but not decal tile mode.
-    return false;
+    src_sampler_descriptor.width_address_mode =


jonahwilliams · 2023-10-05T13:48:32Z

impeller/entity/shaders/blending/ios/framebuffer_blend.vert

@@ -1,3 +1,5 @@
+#version 200


chinmaygarde · 2023-10-05T15:06:10Z

impeller/renderer/backend/gles/capabilities_gles.h

@@ -15,7 +15,7 @@ namespace impeller {
 class ProcTableGLES;

 struct CapabilitiesGLES {


It's really odd that this doesn't extend Capabilities like CapabilitiesVK and we have to pipe these in later. I guess that base class came after the OpenGL ES prototype. Something to tackle later.

chinmaygarde · 2023-10-05T15:08:50Z

impeller/renderer/backend/gles/capabilities_gles.h

@@ -56,6 +56,8 @@ struct CapabilitiesGLES {
  // May be 0.
  size_t num_shader_binary_formats = 0;

+  bool supports_framebuffer_fetch = false;


Perhaps just a comment that says the extension that needs to be supported.

chinmaygarde · 2023-10-05T15:10:36Z

impeller/renderer/backend/gles/capabilities_gles.cc

+    GLint extension_count = 0;
+    gl.GetIntegerv(GL_NUM_EXTENSIONS, &extension_count);
+
+    std::set<std::string> extensions;


Nit: Why toss it in a set first instead of just strncmping it iterating over GetStringi?

I was thinking about the additional extension checks we'll need for MSAA, ssbo, et cetera

Removed, Description does this already

jonahwilliams · 2023-10-05T17:18:04Z

impeller/compiler/compiler.cc

@@ -155,6 +155,9 @@ static CompilerBackend CreateGLSLCompiler(const spirv_cross::ParsedIR& ir,
                             ? source_options.gles_language_version
                             : 100;
    sl_options.es = true;
+    if (source_options.type == SourceType::kFragmentShader) {


TODO: verify if this makes the extension required in all shaders. If so, we'll need to add a check

This was adding the extension to all shaders so now this is configured via an impellerc parameter

jonahwilliams · 2023-10-06T17:10:42Z

Still todo: update malioc diff to skip diffing on framebuffer fetch shaders (not supported)

jonahwilliams · 2023-10-06T18:38:25Z

Moving to WIP while I handle some foundational stuff.

From #46585 For Framebuffer fetch and other changes we should refactor the CapabilitiesGLES into a regular capabilities.

dnfield · 2023-10-10T18:19:42Z

impeller/renderer/backend/gles/capabilities_gles.cc

+static std::string kFramebufferFetchExtension =
+    "GL_EXT_shader_framebuffer_fetch";


Make this a constexpr std::string_view here

did const constexpr char* for similar effect without more refactoring.

dnfield

LGTM with nit

flutter/engine#46585)

…136292) flutter/engine@702f366...bdeb534 2023-10-10 [email protected] Fix high FPS screen flicker of Platform Views when using ImageReaderPlatformViewRenderTarget (flutter/engine#46724) 2023-10-10 [email protected] Prepare to move new folders into `third_party/` by adding a `.gitignore`. (flutter/engine#46729) 2023-10-10 [email protected] Use x86 machines for ios builds. (flutter/engine#46726) 2023-10-10 [email protected] Remove workaround for older versions of MSVC. (flutter/engine#46689) 2023-10-10 [email protected] Roll Skia from 475286f0f6f1 to 06145491fd17 (1 revision) (flutter/engine#46728) 2023-10-10 [email protected] [Impeller] Implement framebuffer fetch support for OpenGLES. (flutter/engine#46585) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

From #46585 For Framebuffer fetch and other changes we should refactor the CapabilitiesGLES into a regular capabilities.

flutter/flutter#120223 for OpenGLES. Checks for support of the framebuffer fetch extension: https://registry.khronos.org/OpenGL/extensions/EXT/EXT_shader_framebuffer_fetch.txt . This is supported on a Pixel 6 at least, we should double check the distribution of the extension. ![d3c](https://github.com/flutter/engine/assets/8975114/d2392dc8-e1b1-4084-ac5d-c5744c651a39)

jonahwilliams added 2 commits October 5, 2023 06:37

[Impeller] implement framebuffer fetch support for OpenGLES.

dd3da7d

++

2c2a890

github-actions bot added platform-android e: impeller labels Oct 5, 2023

jonahwilliams commented Oct 5, 2023

View reviewed changes

++

939eec8

chinmaygarde approved these changes Oct 5, 2023

View reviewed changes

chinmaygarde changed the title ~~[Impeller] implement framebuffer fetch support for OpenGLES.~~ [Impeller] Implement framebuffer fetch support for OpenGLES. Oct 5, 2023

chinmaygarde assigned jonahwilliams Oct 5, 2023

jonahwilliams commented Oct 5, 2023

View reviewed changes

make configurable.

2500a35

jonahwilliams mentioned this pull request Oct 6, 2023

[Impeller] Refactor CapabilitiesGLES into a Capabilties. #46621

Merged

jonahwilliams added the Work in progress (WIP) Not ready (yet) for review! label Oct 6, 2023

jonahwilliams mentioned this pull request Oct 6, 2023

Need a way to disable malioc diff testing for shader + GPU combinations that aren't supported flutter/flutter#136080

Closed

auto-submit bot pushed a commit that referenced this pull request Oct 6, 2023

[Impeller] Refactor CapabilitiesGLES into a Capabilties. (#46621)

63f0080

From #46585 For Framebuffer fetch and other changes we should refactor the CapabilitiesGLES into a regular capabilities.

jonahwilliams added 6 commits October 6, 2023 12:13

Merge branch 'main' of github.com:flutter/engine into fix_tex_i_error

4c67b47

++

0e8be07

++

f377276

++

d07d929

Merge branch 'main' of github.com:flutter/engine into fix_tex_i_error

45dc659

++

cfa0030

jonahwilliams removed the Work in progress (WIP) Not ready (yet) for review! label Oct 10, 2023

jonahwilliams requested a review from dnfield October 10, 2023 17:30

dnfield reviewed Oct 10, 2023

View reviewed changes

dnfield approved these changes Oct 10, 2023

View reviewed changes

make extensions const char*

8a3eddc

jonahwilliams added the autosubmit Merge PR when tree becomes green via auto submit App label Oct 10, 2023

auto-submit bot merged commit 657af19 into flutter:main Oct 10, 2023

engine-flutter-autoroll mentioned this pull request Oct 10, 2023

Roll Flutter Engine from 702f366b1c5d to 7fb5d07b186d (3 revisions) flutter/flutter#136289

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 10, 2023

657af19f9 [Impeller] Implement framebuffer fetch support for OpenGLES. (

8911b93

flutter/engine#46585)

engine-flutter-autoroll mentioned this pull request Oct 10, 2023

Roll Flutter Engine from 702f366b1c5d to bdeb53455f7c (6 revisions) flutter/flutter#136292

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 10, 2023

657af19f9 [Impeller] Implement framebuffer fetch support for OpenGLES. (

e05485f

flutter/engine#46585)

jonahwilliams deleted the fix_tex_i_error branch October 12, 2023 17:51

harryterkelsen pushed a commit that referenced this pull request Oct 23, 2023

[Impeller] Refactor CapabilitiesGLES into a Capabilties. (#46621)

a933ef8

From #46585 For Framebuffer fetch and other changes we should refactor the CapabilitiesGLES into a regular capabilities.

		@@ -15,7 +15,7 @@ namespace impeller {
		class ProcTableGLES;

		struct CapabilitiesGLES {

		static std::string kFramebufferFetchExtension =
		"GL_EXT_shader_framebuffer_fetch";

[Impeller] Implement framebuffer fetch support for OpenGLES. #46585

[Impeller] Implement framebuffer fetch support for OpenGLES. #46585

Uh oh!

Conversation

jonahwilliams commented Oct 5, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

flutter-dashboard bot commented Oct 5, 2023

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jonahwilliams commented Oct 6, 2023

Uh oh!

jonahwilliams commented Oct 6, 2023

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dnfield left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

jonahwilliams commented Oct 5, 2023 •

edited

Loading