Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Reland "Expose more methods on ui.Paragraph: lines" (#47584) #47623

Merged
merged 2 commits into from
Nov 2, 2023

Conversation

LongCatIsLooong
Copy link
Contributor

@LongCatIsLooong LongCatIsLooong commented Nov 2, 2023

The diff is in this commit.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@github-actions github-actions bot added the platform-web Code specifically for the web engine label Nov 2, 2023
@LongCatIsLooong LongCatIsLooong marked this pull request as ready for review November 2, 2023 22:38
@LongCatIsLooong LongCatIsLooong added autosubmit Merge PR when tree becomes green via auto submit App and removed platform-web Code specifically for the web engine labels Nov 2, 2023
@auto-submit auto-submit bot merged commit 5871f52 into flutter:main Nov 2, 2023
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Nov 3, 2023
…137811)

flutter/engine@dd620fc...57768e1

2023-11-02 [email protected] Roll Skia from 86d15e651ae0 to 3b8e2b391d03 (1 revision) (flutter/engine#47627)
2023-11-02 [email protected] Reland "Expose more methods on ui.Paragraph: lines" (#47584) (flutter/engine#47623)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@LongCatIsLooong LongCatIsLooong deleted the reland-47584 branch November 3, 2023 02:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
autosubmit Merge PR when tree becomes green via auto submit App
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants