Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Reverts specialization constant PR and one change that used it #47650

Merged
merged 2 commits into from
Nov 3, 2023

Conversation

zanderso
Copy link
Member

@zanderso zanderso commented Nov 3, 2023

Reverts 79461cd and f899cc7

Copy link
Member

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zanderso zanderso added the autosubmit Merge PR when tree becomes green via auto submit App label Nov 3, 2023
@zanderso zanderso merged commit 6844143 into flutter:main Nov 3, 2023
@zanderso zanderso deleted the revert-sc branch November 3, 2023 16:03
auto-submit bot pushed a commit that referenced this pull request Nov 3, 2023
#47651)

This reverts commit f899cc7.

This is the same revert as #47650, but for the 3.17 release branch.
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 3, 2023
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Nov 3, 2023
…137857)

flutter/engine@72262a2...d5ccb5b

2023-11-03 [email protected] [Impeller] add example of testing entity with "real" HAL instead of mocking. (flutter/engine#47631)
2023-11-03 [email protected] Roll Dart SDK from 3c45f68cd7c2 to 529fcd5bdffc (3 revisions) (flutter/engine#47655)
2023-11-03 [email protected] Reverts specialization constant PR and one change that used it (flutter/engine#47650)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
autosubmit Merge PR when tree becomes green via auto submit App e: impeller
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants