This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Don't use Skia BUILD.gn files #47677
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
platform-ios
platform-android
platform-web
zanderso
force-pushed
the
mv-skia
branch
4 times, most recently
from
88ca1d7 to
8de507a
Compare
|
@kjlubick I'd like to get your thoughts on this approach. Instead of starting from the Chrome BUILD.gn file, I copied https://github.com/google/skia/blob/main/BUILD.gn and trimmed it down. |
kjlubick
suggested changes
Nov 6, 2023
| sources = [ "$_skia_root/src/ports/SkFontMgr_custom.cpp" ] | ||
| } | ||
|
|
||
| optional("fontmgr_custom_directory") { |
There was a problem hiding this comment.
You might be able to trim a few of these fontmgr configurations
There was a problem hiding this comment.
Yeah, good point. My plan is to do some deeper cleanups in a follow-up once this is landed and working.
kjlubick
approved these changes
Nov 7, 2023
jason-simmons
approved these changes
Nov 7, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 7, 2023
fluttermirroringbot
pushed a commit
to flutter/flutter
that referenced
this pull request
Nov 7, 2023
…138034) flutter/engine@1b20752...f8961d2 2023-11-07 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[Impeller] Add support for specialization constants redux." (flutter/engine#47762) 2023-11-07 [email protected] [Impeller] added tests for matrices (flutter/engine#47754) 2023-11-07 [email protected] Roll Skia from 62fc1374cc5d to 030e21befbc9 (2 revisions) (flutter/engine#47756) 2023-11-07 [email protected] [ios] making objective-C smart pointers support ARC (flutter/engine#47612) 2023-11-07 [email protected] Don't use Skia BUILD.gn files (flutter/engine#47677) 2023-11-07 [email protected] [Impeller] Add support for specialization constants redux. (flutter/engine#47678) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new
BUILD.gnfiles in the Engine tree can't go underbuild/secondarybecause Skia still has its own, and they'd be selected first. So, this PR puts the newBUILD.gnfiles underflutter/skia.