This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Impeller] Create a global Vulkan instance in PlaygroundImplVK to prevent SwiftShader from being unloaded after a test completes #47781
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
…vent SwiftShader from being unloaded after a test completes Libcxx is leaking a thread-local storage key each time SwiftShader is loaded and unloaded. If a test's Vulkan instance is the only one in the process, then SwiftShader will be unloaded after the test ends. If many Vulkan playground tests run in a suite, then eventually the leak will cause the process to exceed its limit of TLS keys and the suite will fail. The process can ensure that SwiftShader remains loaded by holding another Vulkan instance that persists across all tests in the suite. Fixes flutter/flutter#138028
jason-simmons
force-pushed
the
bug_138028
branch
from
aa0261f to
adac01d
Compare
bdero
approved these changes
Nov 8, 2023
This was referenced Nov 8, 2023
|
Changes to |
auto-submit bot
pushed a commit
to flutter/cocoon
that referenced
this pull request
Nov 8, 2023
…o. (#3240) * `impeller/fixtures` contains only test fixtures. * `impeller/golden_tests` contains a test harness for goldens. * `impeller/playground` contains a test harness that spawns Impeller backends. Also used for capturing goldens. Patch where this was noticed: flutter/engine#47781
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 8, 2023
…lVK to prevent SwiftShader from being unloaded after a test completes (flutter/engine#47781)
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Nov 8, 2023
…138113) flutter/engine@21f055f...b3af5d6 2023-11-08 [email protected] [Impeller] Create a global Vulkan instance in PlaygroundImplVK to prevent SwiftShader from being unloaded after a test completes (flutter/engine#47781) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Libcxx is leaking a thread-local storage key each time SwiftShader is loaded and unloaded. If a test's Vulkan instance is the only one in the process, then SwiftShader will be unloaded after the test ends. If many Vulkan playground tests run in a suite, then eventually the leak will cause the process to exceed its limit of TLS keys and the suite will fail.
The process can ensure that SwiftShader remains loaded by holding another Vulkan instance that persists across all tests in the suite.
Fixes flutter/flutter#138028