This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[macOS] Allocate textures as unique_ptr earlier #47786
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This cleans up several places where instead of allocating a std::unique_ptr immediately, we were making allocations with the new operator, then later wrapping in a unique_ptr. The previous code was correct but there was no reason not to allocate a unique_ptr immediately. This code makes no semantic changes; just applies a stylistic improvement that makes the code very slightly safer.
cbracken
force-pushed
the
external-texture-make_unique
branch
from
9acc933 to
fa1643d
Compare
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 8, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Nov 9, 2023
…138116) flutter/engine@b3af5d6...233bd62 2023-11-08 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Upgrade Android SDK to 34 "UpsideDownCake"" (flutter/engine#47834) 2023-11-08 [email protected] Roll Skia from e585bb68893b to 1241a903cd33 (2 revisions) (flutter/engine#47830) 2023-11-08 [email protected] Upgrade Android SDK to 34 "UpsideDownCake" (flutter/engine#47609) 2023-11-08 [email protected] [macOS] Allocate textures as unique_ptr earlier (flutter/engine#47786) 2023-11-08 [email protected] Reland "[Impeller] add support for Skia concept of RRect::isSimple needed for DL dispatching" (flutter/engine#47824) 2023-11-08 [email protected] Roll Skia from e2b8ebe16203 to e585bb68893b (7 revisions) (flutter/engine#47826) 2023-11-08 [email protected] [Impeller] Add support for specialization constants (III). (flutter/engine#47765) 2023-11-08 [email protected] [Impeller] Documented the 2 step in the gaussian blur. (flutter/engine#47822) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This cleans up several places where instead of allocating a std::unique_ptr immediately, we were making allocations with the new operator, then later wrapping in a unique_ptr. The previous code was correct but there was no reason not to allocate a unique_ptr immediately.
This code makes no semantic changes; just applies a stylistic improvement that makes the code very slightly safer.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.