Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Remove unused metadata in DEPS from vuln scanning #48995

Merged
merged 3 commits into from
Dec 14, 2023

Conversation

sealesj
Copy link
Contributor

@sealesj sealesj commented Dec 13, 2023

These upstream links (used in vulnerability scanning) are not needed since the references to the deps are no longer used.
Part of simplifying metadata for the vuln scan process, context in b/248564768.

If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@sealesj sealesj added the Work in progress (WIP) Not ready (yet) for review! label Dec 13, 2023
@sealesj sealesj marked this pull request as ready for review December 14, 2023 20:01
@sealesj sealesj changed the title Remove unused metadata Remove unused metadata in DEPS from vuln scanning Dec 14, 2023
@sealesj sealesj removed the Work in progress (WIP) Not ready (yet) for review! label Dec 14, 2023
@sealesj sealesj added the autosubmit Merge PR when tree becomes green via auto submit App label Dec 14, 2023
@auto-submit auto-submit bot merged commit 6fa8e76 into flutter:main Dec 14, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 14, 2023
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Dec 14, 2023
…140180)

flutter/engine@0e7248d...0b0fab8

2023-12-14 [email protected] [Impeller] distinguish between no clear color and transparent black clear color. (flutter/engine#49038)
2023-12-14 [email protected] Unpin mac_toolchain version (flutter/engine#48994)
2023-12-14 [email protected] [Impeller] Turned on new blur. (flutter/engine#48472)
2023-12-14 [email protected] Remove unused metadata in DEPS from vuln scanning (flutter/engine#48995)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
auto-submit bot added a commit to flutter/flutter that referenced this pull request Dec 15, 2023
…isions)" (#140194)

Reverts #140180
Initiated by: zanderso
This change reverts the following previous change:
Original Description:

flutter/engine@0e7248d...0b0fab8

2023-12-14 [email protected] [Impeller] distinguish between no clear color and transparent black clear color. (flutter/engine#49038)
2023-12-14 [email protected] Unpin mac_toolchain version (flutter/engine#48994)
2023-12-14 [email protected] [Impeller] Turned on new blur. (flutter/engine#48472)
2023-12-14 [email protected] Remove unused metadata in DEPS from vuln scanning (flutter/engine#48995)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 15, 2023
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Dec 15, 2023
…140195)

flutter/engine@0e7248d...4cb3ba7

2023-12-15 [email protected] Roll Skia from 79f23e8d8b5d to cd2f06086c96 (1 revision) (flutter/engine#49069)
2023-12-15 [email protected] Roll Dart SDK from 0471164827b9 to f1e37ed8917e (1 revision) (flutter/engine#49065)
2023-12-15 [email protected] [Impeller] impellerc: delete unused code (flutter/engine#49061)
2023-12-15 [email protected] [Impeller] split out gradient tests from aiks_unittests (flutter/engine#49050)
2023-12-15 [email protected] Revert "[Impeller] Turned on new blur." (flutter/engine#49062)
2023-12-14 [email protected] Fix header-guard naming convention in `shell/`. (flutter/engine#49006)
2023-12-14 [email protected] Manual roll of Dart SDK from a677378ae254 to 0471164827b9 (flutter/engine#49054)
2023-12-14 [email protected] Rename `font-subset` to `font_subset`. (flutter/engine#49051)
2023-12-14 [email protected] Roll Skia from 92935b91193a to 79f23e8d8b5d (1 revision) (flutter/engine#49056)
2023-12-14 [email protected] Suppress warning for the new Activity library. (flutter/engine#49046)
2023-12-14 [email protected] [Impeller] distinguish between no clear color and transparent black clear color. (flutter/engine#49038)
2023-12-14 [email protected] Unpin mac_toolchain version (flutter/engine#48994)
2023-12-14 [email protected] [Impeller] Turned on new blur. (flutter/engine#48472)
2023-12-14 [email protected] Remove unused metadata in DEPS from vuln scanning (flutter/engine#48995)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
autosubmit Merge PR when tree becomes green via auto submit App
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants