This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Impeller] remove Buffer type and associated abstractions. #49702
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Friendly ping :) |
bdero
approved these changes
Jan 12, 2024
jonahwilliams
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 12, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 12, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jan 12, 2024
…141489) flutter/engine@418c9e9...b8e5d47 2024-01-12 [email protected] [Impeller] move TrackedObjectsVK to separate file. (flutter/engine#49773) 2024-01-12 [email protected] Add gclient_variables back for linux_license and fix the excluded files (flutter/engine#49775) 2024-01-12 [email protected] [Impeller] Descriptor pool incremental allocation. (flutter/engine#49686) 2024-01-12 [email protected] Relands: Refactors RBE support (flutter/engine#49660) 2024-01-12 [email protected] [Impeller] finish migration to new render pass API. (flutter/engine#49740) 2024-01-12 [email protected] [Impeller] remove Buffer type and associated abstractions. (flutter/engine#49702) 2024-01-12 [email protected] Remove `gclient_variables` from `linux_license.json` (flutter/engine#49766) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that the HostBuffer isn't implementing Buffer, there is really no reason to have a Buffer/DeviceBuffer split. make BufferViews use a DeviceBuffer, and remove the data ptr from buffer views (as we can always reach into the device buffer).
Makes some other cleanups too, since we always use a std::shared_ptr, then we can eliminated the shared_from_this call for AsBufferView by making this a static method.