This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Android] Reset IME state in TextInputPlugin.clearTextInputClient #49829
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinmc
approved these changes
Jan 17, 2024
bleroux
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 18, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jan 18, 2024
…141759) flutter/engine@bfdc0c5...873449c 2024-01-18 [email protected] [Android] Reset IME state in TextInputPlugin.clearTextInputClient (flutter/engine#49829) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
This was referenced Jan 29, 2024
|
@justinmc WDYT of reverting this change in order to fix the following regression: flutter/flutter#148673? I can repro this even on Android API 30 so this is not similar to flutter/flutter#148117. We can probably find another way to make it possible to call Another option would be to call it only for some particular |
|
Discussed offline, but I'm hoping we don't have to revert this since the two bugs fixed here are arguably worse than flutter/flutter#148673. |
auto-submit bot
pushed a commit
that referenced
this pull request
Jul 18, 2024
## Description This PR restricts the call to `restartInput` which was added in #49829. The restart is called when input action is null, DONE, or NONE. ## Related Issue Fixes flutter/flutter#148673. ## Tests Updates 1 test, adds 3 tests.
auto-submit bot
pushed a commit
that referenced
this pull request
Aug 1, 2024
## Description This PR reverts two commits #49829 and #53662. The main change was in #49829. #53662 was a follow-up to mitigate the impact of #49829. ## Related Issue Fixes flutter/flutter#148530 Fixes flutter/flutter#152620 Reopens flutter/flutter#70546. Reopens flutter/flutter#51478
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR calls Android API
InputMethodManager.restartInputto reset IMEs internal states. Otherwise some IMEs (Gboard for instance) keep reacting based on the previous input configuration until a new configuration is set.restartInputis called in several places, for instance in https://github.com/AndroidSDKSources/android-sdk-sources-for-api-level-34/blob/f2197987748faef78e869662ae1fd039daa22a63/android/widget/TextView.java#L2458.TextFieldis focused (it is mainly called insetTextInputEditingState).Related Issue
Fixes flutter/flutter#70546.
Fixes flutter/flutter#51478
Tests
Adds 1 test.