This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Adding ignore paths to cache test #49874
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keyonghan
reviewed
Jan 18, 2024
keyonghan
approved these changes
Jan 18, 2024
zanderso
approved these changes
Jan 18, 2024
| @@ -130,6 +130,10 @@ targets: | |||
| "builder", | |||
| "git" | |||
| ] | |||
| ignore_cache_paths: >- | |||
There was a problem hiding this comment.
Reminder to update https://github.com/flutter/cocoon/blob/main/CI_YAML.md#properties. It looks like some of the other properties might also be missing docs there?
There was a problem hiding this comment.
You got it! I will make sure to open that before submitting. Though this might be specific to engine_v2...
Will do. I am going to run a few tests first before merging though. Will merge today before lunch. |
|
Ran a few tests but could not get the condition of the cache needing an update. So will merge then switch back to prod after some monitoring. Leaving in staging for now is safer. |
ricardoamador
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 19, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jan 19, 2024
…141894) flutter/engine@c953c83...f2b441a 2024-01-19 [email protected] Reland: Encode directly to command buffer. (flutter/engine#49821) 2024-01-19 [email protected] Roll Skia from 2536dc6fef1d to c09908c48f14 (6 revisions) (flutter/engine#49899) 2024-01-19 [email protected] [Impeller] Documentation for SurfaceContextVK (flutter/engine#49882) 2024-01-19 [email protected] Adding ignore paths to cache test (flutter/engine#49874) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding exclusion paths to the Mac builder_cache target to avoid archiving symlinks in the SDKs or other unwanted packages. Symlinks cause issues with the CAS archiving functionality. We have opened a bug for the LUCI team regarding this as well.
Companion CL in recipes is here: https://flutter-review.googlesource.com/c/recipes/+/54110
List which issues are fixed by this PR. You must list at least one issue.
Fixes flutter/flutter#141688
If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.