This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Replace SkColorSpace::filterColor with filterColor4f #50821
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The old API is deprecated. The new one operates on float colors, but is also explicit about the color space of the source color (and the working space of the filter). Bug: b/40040795
chinmaygarde
approved these changes
Feb 23, 2024
flar
approved these changes
Feb 23, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 23, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Feb 23, 2024
…144028) flutter/engine@0f3ad23...5f99a6c 2024-02-23 [email protected] Roll Skia from bb8a7832a6f4 to c7f8e0e6f3c2 (3 revisions) (flutter/engine#50911) 2024-02-23 [email protected] Replace SkColorSpace::filterColor with filterColor4f (flutter/engine#50821) 2024-02-23 [email protected] Roll Dart SDK from 52111952d91b to 7f6eccd65255 (1 revision) (flutter/engine#50910) 2024-02-23 [email protected] Roll Fuchsia Linux SDK from j9cJ94K-T1i3u5xGh... to sO-oG6KoeFlPK2WLR... (flutter/engine#50907) 2024-02-23 [email protected] [Impeller] Make StC work for Position+UV buffers. (flutter/engine#50900) 2024-02-23 [email protected] Roll Dart SDK from 957130770e7d to 52111952d91b (1 revision) (flutter/engine#50906) 2024-02-23 [email protected] Roll Skia from 14b5c1a4627a to bb8a7832a6f4 (1 revision) (flutter/engine#50905) 2024-02-23 [email protected] Roll Skia from 5a0a82af7796 to 14b5c1a4627a (1 revision) (flutter/engine#50904) 2024-02-23 [email protected] Roll Dart SDK from e2f2d9b464e9 to 957130770e7d (2 revisions) (flutter/engine#50903) 2024-02-23 [email protected] Roll Skia from 254b27e90e3c to 5a0a82af7796 (1 revision) (flutter/engine#50902) 2024-02-23 [email protected] Move ban-plugin-java script into separate file and improve testing. (flutter/engine#50875) 2024-02-23 [email protected] Provide a subset of `adb logcat` logs streaming during scenario_app testing (flutter/engine#50886) 2024-02-23 [email protected] Remove obsolete `cache_root` property (flutter/engine#50894) 2024-02-23 [email protected] Roll Skia from 58772db6bc46 to 254b27e90e3c (1 revision) (flutter/engine#50896) 2024-02-23 [email protected] Remove unused drone_dimension field (flutter/engine#50893) 2024-02-22 [email protected] Remove unused property from `Linux Web Framework tests` (flutter/engine#50891) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from j9cJ94K-T1i3 to sO-oG6KoeFlP If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old API is deprecated. The new one operates on float colors, but is also explicit about the color space of the source color (and the working space of the filter).
Bug: b/40040795