Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[Fuchsia] Use shared gn-sdk from chromium #50855

Merged
merged 41 commits into from
Feb 27, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
41 commits
Select commit Hold shift + click to select a range
b01176f
lets go
zijiehe-google-com Feb 21, 2024
211729f
double src
zijiehe-google-com Feb 21, 2024
06f5e27
gni
zijiehe-google-com Feb 22, 2024
8d07993
format
zijiehe-google-com Feb 22, 2024
8259960
Merge branch 'flutter:main' into main
zijiehe-google-com Feb 22, 2024
20bc714
cmc_compile
zijiehe-google-com Feb 22, 2024
bb508ed
output_file
zijiehe-google-com Feb 22, 2024
1536dfb
missing
zijiehe-google-com Feb 22, 2024
66275b5
system_tests
zijiehe-google-com Feb 22, 2024
684d782
format
zijiehe-google-com Feb 22, 2024
10f95a0
undo
zijiehe-google-com Feb 22, 2024
1990650
remove gtest_runner.shard
zijiehe-google-com Feb 23, 2024
cf80d59
Merge branch 'flutter:main' into main
zijiehe-google-com Feb 23, 2024
552bf9e
no output_file
zijiehe-google-com Feb 23, 2024
cda22f8
Revert "no output_file"
zijiehe-google-com Feb 23, 2024
aec271e
Restore run_tests_test
zijiehe-google-com Feb 23, 2024
194e083
Merge branch 'flutter:main' into main
zijiehe-google-com Feb 23, 2024
f4d7cee
Update gn-sdk
zijiehe-google-com Feb 23, 2024
43cb29e
prepare-package_inputs
zijiehe-google-com Feb 23, 2024
e9b6333
Revert "prepare-package_inputs"
zijiehe-google-com Feb 23, 2024
da94851
fuchsia_ar
zijiehe-google-com Feb 23, 2024
585e1ea
cmc_compile
zijiehe-google-com Feb 23, 2024
242be77
format
zijiehe-google-com Feb 23, 2024
f3e9eef
TODO
zijiehe-google-com Feb 23, 2024
0c0afa1
TODO
zijiehe-google-com Feb 23, 2024
a7ce7ad
Merge branch 'main' into main
zijiehe-google-com Feb 23, 2024
b100854
TODO
zijiehe-google-com Feb 23, 2024
76aa7bc
Merge branch 'main' into main
zijiehe-google-com Feb 23, 2024
c744fcc
Merge branch 'main' into main
zijiehe-google-com Feb 23, 2024
8a47163
Merge branch 'main' into main
zijiehe-google-com Feb 24, 2024
db0ef5b
update gn-sdk
zijiehe-google-com Feb 24, 2024
cd02ec2
Merge branch 'main' into main
zijiehe-google-com Feb 24, 2024
4994dec
Merge branch 'main' into main
zijiehe-google-com Feb 24, 2024
2ee0e8b
Merge branch 'main' into main
zijiehe-google-com Feb 26, 2024
45fc483
Merge branch 'main' into main
zijiehe-google-com Feb 26, 2024
0a47328
Merge branch 'main' into main
zijiehe-google-com Feb 26, 2024
d3df72a
Merge branch 'main' into main
zijiehe-google-com Feb 26, 2024
0e61e42
Merge branch 'main' into main
zijiehe-google-com Feb 26, 2024
1b84444
Merge branch 'main' into main
zijiehe-google-com Feb 26, 2024
659eef5
Merge branch 'main' into main
zijiehe-google-com Feb 26, 2024
7c3b362
Merge branch 'main' into main
zijiehe-google-com Feb 27, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -139,3 +139,6 @@ app.*.symbols

# The test-scripts from Chromium and managed by DEPS and gclient.
/tools/fuchsia/test_scripts

# The gn-sdk from Chromium and managed by DEPS and gclient.
/tools/fuchsia/gn-sdk
14 changes: 14 additions & 0 deletions DEPS
Original file line number Diff line number Diff line change
Expand Up @@ -254,6 +254,10 @@ vars = {
# will be used altogether with fuchsia-sdk to setup the build / test
# environment.
'fuchsia_test_scripts_version': 'vf8imeAzGv_gjYQDoqub2laI-6nkB3gQNiGuVaFForMC',

# The version / instance id of the cipd:chromium/fuchsia/gn-sdk which will be
# used altogether with fuchsia-sdk to generate gn based build rules.
'fuchsia_gn_sdk_version': 'l8zShEOXGGjtLYRulEX5CjT2RemKvUPOT6L-uXy41tMC',
}

gclient_gn_args_file = 'src/third_party/dart/build/config/gclient_args.gni'
Expand Down Expand Up @@ -1020,6 +1024,16 @@ deps = {
'dep_type': 'cipd',
},

'src/flutter/tools/fuchsia/gn-sdk': {
'packages': [
{
'package': 'chromium/fuchsia/gn-sdk',
'version': Var('fuchsia_gn_sdk_version'),
}
],
'dep_type': 'cipd',
},

'src/third_party/impeller-cmake-example': {
'url': Var('flutter_git') + '/third_party/impeller-cmake-example.git' + '@' + 'c44e8093972c969acf171be72591e408a85fdc53',
'condition': 'download_impeller_cmake_example',
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -53,3 +53,14 @@ if (fuchsia_sdk_id == "") {
_meta = read_file(fuchsia_sdk_manifest_file, "json")
fuchsia_sdk_id = _meta.id
}

declare_args() {
# Specify a readelf_exec path to use. If not specified, the host's system
# executable will be used. Passed to populate_build_id_dir.py and
# prepare_package_inputs.py via the --readelf-exec flag.
# Must be a GN path (not an absolute path) since it is adjusted with
# rebase_path().
if (!defined(fuchsia_sdk_readelf_exec)) {
fuchsia_sdk_readelf_exec = ""
}
}
2 changes: 1 addition & 1 deletion shell/platform/fuchsia/dart-pkg/zircon/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import("//build/fuchsia/sdk.gni")
import("//flutter/testing/testing.gni")
import("//flutter/tools/fuchsia/dart/dart_library.gni")
import("//flutter/tools/fuchsia/flutter/flutter_component.gni")
import("//flutter/tools/fuchsia/gn-sdk/package.gni")
import("//flutter/tools/fuchsia/gn-sdk/src/package.gni")

config("zircon_config") {
include_dirs = [ "." ]
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@

{
include: [
"gtest_runner.shard.cml",
"sys/testing/gtest_runner.shard.cml",
"sys/component/realm_builder_absolute.shard.cml",

// This test needs both the vulkan facet and the hermetic-tier-2 facet,
Expand Down

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import("//build/fuchsia/sdk.gni")

import("//flutter/tools/fuchsia/dart/dart_component.gni")
import("//flutter/tools/fuchsia/dart/dart_library.gni")
import("//flutter/tools/fuchsia/gn-sdk/package.gni")
import("//flutter/tools/fuchsia/gn-sdk/src/package.gni")

dart_library("lib") {
testonly = true
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@

{
include: [
"gtest_runner.shard.cml",
"sys/testing/gtest_runner.shard.cml",
"sys/component/realm_builder_absolute.shard.cml",

// This test needs both the vulkan facet and the hermetic-tier-2 facet,
Expand Down

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
import("//build/fuchsia/sdk.gni")
import("//flutter/tools/fuchsia/dart/dart_library.gni")
import("//flutter/tools/fuchsia/flutter/flutter_component.gni")
import("//flutter/tools/fuchsia/gn-sdk/package.gni")
import("//flutter/tools/fuchsia/gn-sdk/src/package.gni")

dart_library("lib") {
package_name = "child-view"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
// found in the LICENSE file.
{
include: [
"gtest_runner.shard.cml",
"sys/testing/gtest_runner.shard.cml",
"sys/component/realm_builder_absolute.shard.cml",

// This test needs both the vulkan facet and the hermetic-tier-2 facet,
Expand Down

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
import("//build/fuchsia/sdk.gni")
import("//flutter/tools/fuchsia/dart/dart_library.gni")
import("//flutter/tools/fuchsia/flutter/flutter_component.gni")
import("//flutter/tools/fuchsia/gn-sdk/package.gni")
import("//flutter/tools/fuchsia/gn-sdk/src/package.gni")

dart_library("lib") {
package_name = "parent-view"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ assert(is_fuchsia)

import("//build/fuchsia/sdk.gni")
import("//flutter/tools/fuchsia/fuchsia_archive.gni")
import("//flutter/tools/fuchsia/gn-sdk/package.gni")
import("//flutter/tools/fuchsia/gn-sdk/src/package.gni")

group("tests") {
testonly = true
Expand Down

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
// found in the LICENSE file.
{
include: [
"gtest_runner.shard.cml",
"sys/testing/gtest_runner.shard.cml",
"sys/component/realm_builder_absolute.shard.cml",

// This test needs both the vulkan facet and the hermetic-tier-2 facet,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@
import("//build/fuchsia/sdk.gni")
import("//flutter/tools/fuchsia/dart/dart_library.gni")
import("//flutter/tools/fuchsia/flutter/flutter_component.gni")
import("//flutter/tools/fuchsia/gn-sdk/component.gni")
import("//flutter/tools/fuchsia/gn-sdk/package.gni")
import("//flutter/tools/fuchsia/gn-sdk/src/component.gni")
import("//flutter/tools/fuchsia/gn-sdk/src/package.gni")

dart_library("lib") {
package_name = "mouse-input-view"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ assert(is_fuchsia)

import("//build/fuchsia/sdk.gni")
import("//flutter/tools/fuchsia/fuchsia_archive.gni")
import("//flutter/tools/fuchsia/gn-sdk/package.gni")
import("//flutter/tools/fuchsia/gn-sdk/src/package.gni")

group("tests") {
testonly = true
Expand Down

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
// found in the LICENSE file.
{
include: [
"gtest_runner.shard.cml",
"sys/testing/gtest_runner.shard.cml",
"sys/component/realm_builder_absolute.shard.cml",

// This test needs both the vulkan facet and the hermetic-tier-2 facet,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@
import("//build/fuchsia/sdk.gni")
import("//flutter/tools/fuchsia/dart/dart_library.gni")
import("//flutter/tools/fuchsia/flutter/flutter_component.gni")
import("//flutter/tools/fuchsia/gn-sdk/component.gni")
import("//flutter/tools/fuchsia/gn-sdk/package.gni")
import("//flutter/tools/fuchsia/gn-sdk/src/component.gni")
import("//flutter/tools/fuchsia/gn-sdk/src/package.gni")

dart_library("lib") {
testonly = true
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ assert(is_fuchsia)

import("//build/fuchsia/sdk.gni")
import("//flutter/tools/fuchsia/fuchsia_archive.gni")
import("//flutter/tools/fuchsia/gn-sdk/package.gni")
import("//flutter/tools/fuchsia/gn-sdk/src/package.gni")

group("tests") {
testonly = true
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@
import("//build/fuchsia/sdk.gni")
import("//flutter/tools/fuchsia/dart/dart_library.gni")
import("//flutter/tools/fuchsia/flutter/flutter_component.gni")
import("//flutter/tools/fuchsia/gn-sdk/component.gni")
import("//flutter/tools/fuchsia/gn-sdk/package.gni")
import("//flutter/tools/fuchsia/gn-sdk/src/component.gni")
import("//flutter/tools/fuchsia/gn-sdk/src/package.gni")

dart_library("lib") {
package_name = "embedding-flutter-view"
Expand Down

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
// found in the LICENSE file.
{
include: [
"gtest_runner.shard.cml",
"sys/testing/gtest_runner.shard.cml",
"sys/component/realm_builder_absolute.shard.cml",

// This test needs both the vulkan facet and the hermetic-tier-2 facet,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@
import("//build/fuchsia/sdk.gni")
import("//flutter/tools/fuchsia/dart/dart_library.gni")
import("//flutter/tools/fuchsia/flutter/flutter_component.gni")
import("//flutter/tools/fuchsia/gn-sdk/component.gni")
import("//flutter/tools/fuchsia/gn-sdk/package.gni")
import("//flutter/tools/fuchsia/gn-sdk/src/component.gni")
import("//flutter/tools/fuchsia/gn-sdk/src/package.gni")

dart_library("lib") {
package_name = "touch-input-view"
Expand Down
46 changes: 0 additions & 46 deletions tools/fuchsia/compile_cml.py

This file was deleted.

4 changes: 3 additions & 1 deletion tools/fuchsia/fidl/fidl_library.gni
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,9 @@
import("//flutter/tools/executable_action.gni")
import("//flutter/tools/fuchsia/fidl/fidl.gni")
import("//flutter/tools/fuchsia/fidl/toolchain.gni")
import("//flutter/tools/fuchsia/gn-sdk/config/config.gni")
import("//flutter/tools/fuchsia/gn-sdk/src/config/config.gni")

# TODO(zijiehe): May use fidl_library in gn-sdk if possible. - http://crbug.com/40935282

# Generates some representation of a FIDL library that's consumable by Language
# bindings generators.
Expand Down
4 changes: 2 additions & 2 deletions tools/fuchsia/flutter/internal/flutter_dart_component.gni
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,8 @@ import("//flutter/tools/fuchsia/dart/config.gni")
import("//flutter/tools/fuchsia/dart/dart.gni")
import("//flutter/tools/fuchsia/dart/dart_package_config.gni")
import("//flutter/tools/fuchsia/dart/kernel/dart_kernel.gni")
import("//flutter/tools/fuchsia/gn-sdk/cmc.gni")
import("//flutter/tools/fuchsia/gn-sdk/component.gni")
import("//flutter/tools/fuchsia/gn-sdk/src/cmc.gni")
import("//flutter/tools/fuchsia/gn-sdk/src/component.gni")

# Defines a component which will run in a flutter_runner or dart_runner
#
Expand Down
Loading