Actually use Impeller in scenario_app tests

[dnfield]

Right now, the scenario_app tests that claim to use Impeller are not actually using Impeller. This is for a few reasons:

• The arguments passed via instrumentation do not end up by default on the Intent for the Activity that is under test.
• The arguments passed via instrumentation were in the wrong order and not getting sent to instrumentation at all.

This patch updates existing tests to use a new @Rule that reads the arguments from the instrumentation's argument Bundle and injects them into the Intent that we actually pass to the Activity under test. This patch updates the test runner to force initialization of the shell arguments for all tests once and early. It also updates the argument order in the script and adds a verification that Impeller prints that it is being used at least once.

[matanlurey]

LGTM, thanks for doing this!

[auto-submit]

auto label is removed for flutter/engine/50977, due to - The status or check suite Linux linux_android_aot_engine has failed. Please fix the issues identified (or deflake) before re-applying this label.

• The status or check suite Linux linux_android_emulator_skia_tests has failed. Please fix the issues identified (or deflake) before re-applying this label.
• The status or check suite Linux linux_android_emulator_tests has failed. Please fix the issues identified (or deflake) before re-applying this label.

[matanlurey]

@dnfield I am going to hit "Update branch" so we can get my logging improvements and Jonah's crash improvements.

[dnfield]

Something is going wrong in the general case - Impeller is getting used when I run a single test, but not when I run them all.

[dnfield]

I've modified this patch to be a bit simpler and remove a test that does not work with Impeller currently - the test tries to construct a Flutter Engine in an unusual way and ends up hanging when we try to initialize Vulkan for reasons that are not entirely clear to me. I don't think we need to do that though, we have coverage already elsewhere around initializing FlutterEngine objects.

[flutter-dashboard]

Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change).

If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review.

Changes reported for pull request #50977 at sha 0b852a2

[matanlurey]

I took a quick look at the gold digests and they look WAI, the texture tests that are rendering blank are waiting for a combination of #50730 (h/t @chinmaygarde) and flutter/flutter#144199 (h/t @johnmccutchan).

[dnfield]

I'm going to approve the goldens. Chinmay can merge this into his PR and that should give him the test coverage he needs.