Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[scenario] trigger firstFrameLatch on exception. #50981

Merged
merged 2 commits into from
Feb 26, 2024
Merged

[scenario] trigger firstFrameLatch on exception. #50981

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4d942d1
[scenario] trigger firstFrameLatch on exception.
Feb 26, 2024
f741677
just dont return.
Feb 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions ...o_app/android/app/src/main/java/dev/flutter/scenarios/ExternalTextureFlutterActivity.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -417,6 +417,11 @@ private void onImageAvailable(ImageReader reader) {
// IllegalStateException.
// Simply log and return.
Log.i(TAG, "Surface disconnected from ImageWriter", e);

if (onFirstFrame != null) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit:

move this to a finally block and get rid of the other one.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

...alternatively don't return in the catch block

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

onFirstFrame.countDown();
onFirstFrame = null;
}
image.close();
return;
}
Expand Down