Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[Windows] Remove TODONE #51005

Merged
merged 1 commit into from
Feb 27, 2024
Merged

[Windows] Remove TODONE #51005

merged 1 commit into from
Feb 27, 2024

Conversation

loic-sharma
Copy link
Member

@loic-sharma loic-sharma commented Feb 27, 2024 •
edited
Loading

This TODO is TODONE!

Part of flutter/flutter#131616

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@loic-sharma loic-sharma changed the title [Windows] Remove TO-DONE [Windows] Remove TODONE Feb 27, 2024
@loic-sharma loic-sharma added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 27, 2024
@auto-submit auto-submit bot merged commit c79117b into flutter:main Feb 27, 2024
@zanderso zanderso mentioned this pull request Feb 28, 2024
Merged
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Feb 28, 2024
@zanderso
Manual roll Flutter Engine 2461280c38b7 to c79117b706e9 (#144290)
96a390a 
c79117b706 [Windows] Remove TODONE (flutter/engine#51005)
24c7b03ef0 [Windows] Introduce an accessibility plugin (flutter/engine#50975)
c805e43957 Roll Skia from 1beae57ea0dd to c8703c91675e (1 revision) (flutter/engine#51014)
17dff87ef3 [Impeller] various StC fixes for GPU -> CPU readback plus BufferBindingGLES error (flutter/engine#50951)
8457d10473 Roll Dart SDK from be6be2b9ba6e to a0e3c16eea3e (3 revisions) (flutter/engine#51015)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@yaakovschectman yaakovschectman yaakovschectman approved these changes

Assignees
No one assigned
Labels
affects: desktop autosubmit Merge PR when tree becomes green via auto submit App platform-windows
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@loic-sharma @yaakovschectman