Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Support gtest-parallel when running Impeller unit tests #51079

Merged

Conversation

jason-simmons
Copy link
Member

ImpellerC tests that use a temporary directory will append the current process ID to the directory name to avoid collisions.

The temporary directory will also be deleted after each test case completes.

See flutter/flutter#143379

Copy link
Contributor

@matanlurey matanlurey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me! Thanks for looking at this!

ImpellerC tests that use a temporary directory will append the current process ID to the directory name to avoid collisions.

The temporary directory will also be deleted after each test case completes.

See flutter/flutter#143379
@jason-simmons jason-simmons force-pushed the iplr_parallel_compiler_tests branch from 977c72f to 2bd3af4 Compare March 4, 2024 19:38
@jason-simmons jason-simmons added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 4, 2024
@auto-submit auto-submit bot merged commit 9b71d60 into flutter:main Mar 4, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 4, 2024
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Mar 4, 2024
…144570)

flutter/engine@0d8588b...4001881

2024-03-04 [email protected] Reland: [macOS] Use CVDisplayLink to drive repaint (flutter/engine#51126)
2024-03-04 [email protected] Support gtest-parallel when running Impeller unit tests (flutter/engine#51079)
2024-03-04 [email protected] Scenario App: Adds a `run_{count}.{backend}.` file prefix to every run (on CI) (flutter/engine#51102)
2024-03-04 [email protected] Use Instrumentation.waitForIdleSync() after rotation requests. (flutter/engine#51169)
2024-03-04 [email protected] Roll Skia from 9c7d13c05e77 to f65ecbdfb09c (1 revision) (flutter/engine#51170)
2024-03-04 [email protected] Guard against API 22 (flutter/engine#51167)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
autosubmit Merge PR when tree becomes green via auto submit App e: impeller
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants