[Impeller] testing. #51101
[Impeller] testing. #51101
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact "@test-exemption-reviewer" in the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change). If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review. |
|
Super appreciate that you spent time looking into this. 🙏 Thank you. |
|
Golden file changes are available for triage from new commit, Click here to view. |
|
No prob. I think adding the depth attachment to MakeOffscreen actually regressed things again, so I've backed that out to verify that the golden diff goes back to 6 or so. |
|
Yeah it went back to just 8. So I wonder if there are some test specific misconfigurations, or else its something with the blur specifically. |
|
Golden file changes are available for triage from new commit, Click here to view. |
|
oh, the remaining issues are exclusively GLES issues! |
| @@ -76,7 +77,8 @@ std::shared_ptr<Texture> Picture::RenderToTexture( | |||
| /*mip_count=*/1, | |||
| "Picture Snapshot", // label | |||
| RenderTarget::kDefaultColorAttachmentConfig, // color_attachment_config | |||
| std::nullopt // stencil_attachment_config | |||
| RenderTarget:: | |||
| kDefaultStencilAttachmentConfig // stencil_attachment_config | |||
There was a problem hiding this comment.
Just these changes in picture.cc are needed to get us over the line.
There was a problem hiding this comment.
The remaining backdrop blur goldens for GLES were fixed with #51173
Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.
List which issues are fixed by this PR. You must list at least one issue.
If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.