This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Reverts "Reland: [macOS] Use CVDisplayLink to drive repaint (#51126)" #51192
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![auto-submit[bot]](https://avatars.githubusercontent.com/u/14101776?s=60&v=4){kind=small}
This reverts commit 4001881.
auto-submit
bot
added
the
revert of
fluttergithubbot
approved these changes
Mar 5, 2024
auto-submit
bot
deleted the
revert_40018811ec0e364fc7f52e9d29a157f9df5778f3
branch
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 5, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Mar 5, 2024
…144607) flutter/engine@d514a30...17a4b66 2024-03-05 [email protected] Roll Skia from a577399ed6fb to 5839a94bf28b (1 revision) (flutter/engine#51194) 2024-03-05 [email protected] [Impeller] Turn off StC. (flutter/engine#51191) 2024-03-05 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Reland: [macOS] Use CVDisplayLink to drive repaint (#51126)" (flutter/engine#51192) 2024-03-05 [email protected] Roll Skia from 9c62e7b382cf to a577399ed6fb (1 revision) (flutter/engine#51190) 2024-03-05 [email protected] Reland "Remove migration flag and unused header files #50216" (flutter/engine#50259) 2024-03-05 [email protected] Shift git version fetching to tools/gn (flutter/engine#51175) 2024-03-05 [email protected] [fuchsia] Remove now unnecessary diagnostics directory (flutter/engine#51180) 2024-03-05 [email protected] [Impeller] Enable depth buffer clipping & Stencil-then-Cover path rendering. (flutter/engine#50856) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
knopp
added a commit
to knopp/engine
that referenced
this pull request
Mar 5, 2024
…lutter#51126)" (flutter#51192)" This reverts commit 78cecee.
knopp
added a commit
to knopp/engine
that referenced
this pull request
Mar 13, 2024
…lutter#51126)" (flutter#51192)" This reverts commit 78cecee.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #51126
Initiated by: cbracken
Reason for reverting: looks like this regressed Skia benchmarks: https://flutter-flutter-perf.skia.org/e/?keys=Xbf8dce9c233bce34d20e2280e3f1d8db&selected=commit%3D39653%26name%3D%2Carch%3Dintel%2Cbranch%3Dmaster%2Cconfig%3Ddefault%2Cdevice_type%3Dnone%2Cdevice_version%3Dnone%2Chost_type%3Dmac%2Csub_result%3DtimeToFirstFrameRasterizedMicros%2Ctest%3Dflutter_gallery_macos__start_up%2C&xbaroffset=39569
The regression s
Original PR Author: knopp
Reviewed By: {cbracken}
This change reverts the following previous change:
Original Description:
This relands the PR reverted in #51095
Changes since the original PR:
FlutterTimeConverter)FlutterVSyncWaiterdoes not wait for displaylink callback during warmup frame. This should preventtimeToFirstFrameRasterizedMicrosregressions.average_frame_rasterizer_time_millisregressions.Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.