This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Skip impeller goldens on release #51240
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keyonghan
reviewed
Mar 6, 2024
ci/builders/mac_host_engine.json
Outdated
| "--variant", | ||
| "host_release", | ||
| "--type", | ||
| "impeller-golden" | ||
| ], | ||
| "run_if": "main" |
Jasguerrero
added
the
autosubmit
|
My understanding is that the root cause of these tests failing on the release builder is that the role account on the release builders isn't in the ACL to upload to the bucket for SkiaGold. Instead of doing this, can the role account be added to the ACL for the bucket? |
Jasguerrero
removed
the
autosubmit
Moving discussion to email |
zanderso
approved these changes
Mar 7, 2024
Jasguerrero
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 7, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Mar 7, 2024
…144784) flutter/engine@1282895...9e8ccaa 2024-03-07 [email protected] Skip impeller goldens on release (flutter/engine#51240) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
zanderso
added a commit
to zanderso/engine
that referenced
this pull request
Mar 8, 2024
This reverts commit 9e8ccaa.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.