[Impeller] implements blur styles for gradients #51264

gaaclarke · 2024-03-07T21:27:52Z

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
I listed at least one issue that this PR fixes in the description above.
I added new tests to check the change I am making or feature I am adding, or the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
I updated/added relevant documentation (doc comments with ///).
I signed the CLA.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

gaaclarke · 2024-03-07T21:29:39Z

impeller/entity/contents/content_context.h

@@ -408,7 +408,7 @@ class ContentContext {
  ///
  // TODO(bdero): Remove this setting once StC is fully de-risked
  //              https://github.com/flutter/flutter/issues/123671
-  static constexpr bool kEnableStencilThenCover = true;
+  static constexpr bool kEnableStencilThenCover = false;


@bdero this only works if I turn stencil and cover off (of course inner and outer are reversed though)

Taking a look at this now

impeller/entity/contents/filters/gaussian_blur_filter_contents.cc

flutter-dashboard · 2024-03-11T17:54:30Z

Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change).

If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review.

Changes reported for pull request #51264 at sha 71d3189

flutter-dashboard · 2024-03-11T18:32:28Z

Golden file changes are available for triage from new commit, Click here to view.

Changes reported for pull request #51264 at sha 25b61b9

flutter-dashboard · 2024-03-11T23:00:17Z

Golden file changes are available for triage from new commit, Click here to view.

Changes reported for pull request #51264 at sha eccb652

bdero

LGTM

bdero · 2024-03-12T00:00:44Z

(Looks like GaussianBlurStyleInnerGradient might not be rendering right in the goldens though)

bdero · 2024-03-12T00:02:20Z

gaaclarke · 2024-03-12T15:24:27Z

(Looks like GaussianBlurStyleInnerGradient might not be rendering right in the goldens though)

There is an open issue about the gaussian blur not working on opengles. We've deprioritized opengles work though.

…gine#51264)

…ions) (#145006) Manual roll requested by [email protected] flutter/engine@6771307...af1fd17 2024-03-12 [email protected] Try making android scenario app not do animations (flutter/engine#51349) 2024-03-12 [email protected] Roll Dart SDK from 7a2c94fd0a26 to c97f2b303259 (1 revision) (flutter/engine#51345) 2024-03-12 [email protected] Roll Fuchsia Linux SDK from L6_XzizcJqjneCvGA... to UR-nKoLidl7cVLrrN... (flutter/engine#51344) 2024-03-12 [email protected] [Impeller] implements blur styles for gradients (flutter/engine#51264) 2024-03-11 [email protected] [codesign] fix typo in binary path (flutter/engine#51339) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from L6_XzizcJqjn to UR-nKoLidl7c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

github-actions bot added the e: impeller label Mar 7, 2024

gaaclarke commented Mar 7, 2024

View reviewed changes

bdero reviewed Mar 8, 2024

View reviewed changes

impeller/entity/contents/filters/gaussian_blur_filter_contents.cc Outdated Show resolved Hide resolved

gaaclarke mentioned this pull request Mar 8, 2024

[Impeller] mask blurs on ColorSourceContents stretches the contents flutter/flutter#144836

Closed

gaaclarke added 11 commits March 8, 2024 15:29

[Impeller] implemented blur styles for non-solid colors

933be97

got the clip lined up

d66bc18

removed fudge

10386e7

fixed blend

974c3da

stopped sharing the blur_entity since it is being modified

57c8251

moved clipdepth and turn stc back on

f6ac48b

added test for outer

a6b0394

turned stc back off

b0c9cc7

got rid of use after move with explicit ordering

40a3aa4

fixed inner and outer with stencil

aa91d6c

got stencil then cover working and turned back on *sigh*

8a60785

gaaclarke force-pushed the blur-mask-gradients branch from 7eb5d3a to 8a60785 Compare March 8, 2024 23:29

gaaclarke added 5 commits March 8, 2024 15:43

made the closures idempotent

b4c0e22

added a solid case for a gradient, doesn't work with stc

740cf64

got solid working for gradients

288e944

cleaned up clip depth a bit

8921f0d

updated golden

391d967

gaaclarke force-pushed the blur-mask-gradients branch from 20b9f4b to 391d967 Compare March 11, 2024 17:22

gaaclarke marked this pull request as ready for review March 11, 2024 17:22

gaaclarke and others added 2 commits March 11, 2024 10:22

Merge branch 'main' into blur-mask-gradients

71d3189

removed old todo

25b61b9

flutter-dashboard bot added the will affect goldens label Mar 11, 2024

gaaclarke requested a review from bdero March 11, 2024 17:58

started just drawing the original over the blur for solid

eccb652

bdero approved these changes Mar 11, 2024

View reviewed changes

gaaclarke added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 12, 2024

auto-submit bot merged commit de82380 into flutter:main Mar 12, 2024

engine-flutter-autoroll mentioned this pull request Mar 12, 2024

Manual roll Flutter Engine from 67713071563e to af1fd1724986 (5 revisions) flutter/flutter#145006

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 12, 2024

de823801d [Impeller] implements blur styles for gradients (flutter/en…

e3273d8

…gine#51264)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[Impeller] implements blur styles for gradients #51264

[Impeller] implements blur styles for gradients #51264

Uh oh!

gaaclarke commented Mar 7, 2024 •

edited

Loading

Uh oh!

gaaclarke Mar 7, 2024

Uh oh!

bdero Mar 8, 2024

Uh oh!

Uh oh!

flutter-dashboard bot commented Mar 11, 2024

Uh oh!

flutter-dashboard bot commented Mar 11, 2024

Uh oh!

flutter-dashboard bot commented Mar 11, 2024

Uh oh!

bdero left a comment

Uh oh!

bdero commented Mar 12, 2024

Uh oh!

bdero commented Mar 12, 2024

Uh oh!

gaaclarke commented Mar 12, 2024

Uh oh!

Uh oh!

[Impeller] implements blur styles for gradients #51264

[Impeller] implements blur styles for gradients #51264

Uh oh!

Conversation

gaaclarke commented Mar 7, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-launch Checklist

Uh oh!

gaaclarke Mar 7, 2024

Choose a reason for hiding this comment

Uh oh!

bdero Mar 8, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

flutter-dashboard bot commented Mar 11, 2024

Uh oh!

flutter-dashboard bot commented Mar 11, 2024

Uh oh!

flutter-dashboard bot commented Mar 11, 2024

Uh oh!

bdero left a comment

Choose a reason for hiding this comment

Uh oh!

bdero commented Mar 12, 2024

Uh oh!

bdero commented Mar 12, 2024

Uh oh!

gaaclarke commented Mar 12, 2024

Uh oh!

Uh oh!

gaaclarke commented Mar 7, 2024 •

edited

Loading