Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[Impeller] moved tests to aiks_blur_unittests, added warning #51274

Merged
merged 1 commit into from
Mar 8, 2024

Conversation

gaaclarke
Copy link
Member

issue: flutter/flutter#140106

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@gaaclarke gaaclarke requested a review from bdero March 8, 2024 00:14
@gaaclarke gaaclarke assigned matanlurey and unassigned matanlurey Mar 8, 2024
@gaaclarke gaaclarke requested a review from matanlurey March 8, 2024 00:15
Copy link
Member

@bdero bdero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gaaclarke gaaclarke merged commit 68f1d69 into flutter:main Mar 8, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 8, 2024
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Mar 8, 2024
…144817)

flutter/engine@bbb1ed0...bc4abcd

2024-03-08 [email protected] [Impeller] Add mask blur style support to the RRect blur fast path. (flutter/engine#51250)
2024-03-08 [email protected] [Impeller] moved tests to aiks_blur_unittests, added warning (flutter/engine#51274)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants