[Impeller] Use the AHB prefix for utils that work with Android Hardware Buffers. #51298
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact "@test-exemption-reviewer" in the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
chinmaygarde
added
the
autosubmit
|
auto label is removed for flutter/engine/51298, due to - The status or check suite Mac mac_ios_engine has failed. Please fix the issues identified (or deflake) before re-applying this label. |
auto-submit
bot
removed
the
autosubmit
|
The CI failures are due to the recipe assuming Dart will always be in the path. It has been reported in the sheriffs chat. |
…re Buffers. Also doesn't compile the TU on non-Android platforms. Part of flutter#51213 being chopped up. No change in functionality. Just renames and moves stuff around.
chinmaygarde
force-pushed
the
rename_ahb_texture_source
branch
from
86fa629 to
2101add
Compare
chinmaygarde
added
the
autosubmit
…oid Hardware Buffers. (flutter/engine#51298)
…144863) flutter/engine@7541e90...7953662 2024-03-09 [email protected] [Impeller] Use the AHB prefix for utils that work with Android Hardware Buffers. (flutter/engine#51298) 2024-03-09 [email protected] [Impeller] Make DeviceHolder follow convention for backend specific utilities. (flutter/engine#51300) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Also doesn't compile the TU on non-Android platforms.
Part of #51213 being chopped up.
No change in functionality. Just renames and moves stuff around.