Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[Impeller] Use the AHB prefix for utils that work with Android Hardware Buffers. #51298

Merged
merged 1 commit into from
Mar 9, 2024

Conversation

chinmaygarde
Copy link
Member

Also doesn't compile the TU on non-Android platforms.

Part of #51213 being chopped up.

No change in functionality. Just renames and moves stuff around.

@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact "@test-exemption-reviewer" in the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Copy link
Member

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chinmaygarde chinmaygarde added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 8, 2024
Copy link
Contributor

auto-submit bot commented Mar 8, 2024

auto label is removed for flutter/engine/51298, due to - The status or check suite Mac mac_ios_engine has failed. Please fix the issues identified (or deflake) before re-applying this label.

@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Mar 8, 2024
@chinmaygarde
Copy link
Member Author

The CI failures are due to the recipe assuming Dart will always be in the path. It has been reported in the sheriffs chat.

…re Buffers.

Also doesn't compile the TU on non-Android platforms.

Part of flutter#51213 being chopped up.

No change in functionality. Just renames and moves stuff around.
@chinmaygarde chinmaygarde force-pushed the rename_ahb_texture_source branch from 86fa629 to 2101add Compare March 8, 2024 23:50
@chinmaygarde chinmaygarde added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 8, 2024
@auto-submit auto-submit bot merged commit 7953662 into flutter:main Mar 9, 2024
@chinmaygarde chinmaygarde deleted the rename_ahb_texture_source branch March 9, 2024 00:53
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 9, 2024
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Mar 9, 2024
…144863)

flutter/engine@7541e90...7953662

2024-03-09 [email protected] [Impeller] Use the AHB prefix for utils that work with Android Hardware Buffers. (flutter/engine#51298)
2024-03-09 [email protected] [Impeller] Make DeviceHolder follow convention for backend specific utilities. (flutter/engine#51300)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
autosubmit Merge PR when tree becomes green via auto submit App e: impeller platform-android
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants