Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[codesign] fix typo in binary path #51339

Merged
merged 4 commits into from
Mar 11, 2024
Merged

[codesign] fix typo in binary path #51339

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4248182
fix path
XilaiZhang Mar 11, 2024
0f0fbaa
86
XilaiZhang Mar 11, 2024
a263cb8
remove framework
XilaiZhang Mar 11, 2024
b0b66fc
split
XilaiZhang Mar 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sky/tools/create_macos_framework.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -220,7 +220,7 @@ def zip_framework(dst, args):
def zip_xcframework_archive(dst):
filepath_with_entitlements = ''
filepath_without_entitlements = (
'FlutterMacOS.xcframework/macos-arm64_x84_64/'
'FlutterMacOS.xcframework/macos-arm64_x84_64/FlutterMacOS.framework/Versions/A/FlutterMacOS'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ooof, this was my bad. It's not that the path isn't complete, it's that it needs to be x86, not x84

Suggested change
'FlutterMacOS.xcframework/macos-arm64_x84_64/FlutterMacOS.framework/Versions/A/FlutterMacOS'
'FlutterMacOS.xcframework/macos-arm64_x86_64/'

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the catch! Do you happen to have a built zip file of xcframework that I could take a look? (just to double check its file structure)

I thought if there is a binary inside the xcframework folder we would use the full path to the binary

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here's an example: https://storage.googleapis.com/flutter_infra_release/flutter/10331db8f748432d901d566b72ad0ab90f6cd1b9/darwin-x64/framework.zip

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, yeah this would work!

'FlutterMacOS.framework/Versions/A/FlutterMacOS'
)
embed_codesign_configuration(os.path.join(dst, 'entitlements.txt'), filepath_with_entitlements)
Expand Down