Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Add completion callback to Shell::AddView #51659

Merged
merged 8 commits into from
Mar 29, 2024
Merged

Add completion callback to Shell::AddView #51659

merged 8 commits into from
Mar 29, 2024

Conversation

loic-sharma
Copy link
Member

In the future, FlutterEngineAddView will be added to the embedder API to allow embedders to add views. FlutterEngineAddView will accept a callback that notifies the embedder once the view has been added.

This embedder API will be powered by Shell::AddView. This change adds a completion callback to Shell::AddView to prepare for the embedder API.

Design doc: https://flutter.dev/go/multi-view-embedder-apis

Part of flutter/flutter#144806
Part of flutter/flutter#142845

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@loic-sharma loic-sharma mentioned this pull request Mar 25, 2024
Merged
8 tasks
@loic-sharma loic-sharma marked this pull request as ready for review March 25, 2024 22:28
@loic-sharma loic-sharma force-pushed the shell_add_view_callback branch from c110c00 to ecbeecb Compare March 25, 2024 22:32
dkwingsmt
dkwingsmt reviewed Mar 25, 2024
View reviewed changes
dkwingsmt
dkwingsmt reviewed Mar 25, 2024
View reviewed changes
Copy link
Contributor

@dkwingsmt dkwingsmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment.

loic-sharma
loic-sharma commented Mar 25, 2024
View reviewed changes
loic-sharma
loic-sharma commented Mar 25, 2024
View reviewed changes
@loic-sharma loic-sharma force-pushed the shell_add_view_callback branch from dc51cd5 to a9bd747 Compare March 26, 2024 16:25
dkwingsmt
dkwingsmt reviewed Mar 26, 2024
View reviewed changes
@loic-sharma loic-sharma force-pushed the shell_add_view_callback branch from 56b283c to 134f928 Compare March 28, 2024 01:45
@loic-sharma loic-sharma force-pushed the shell_add_view_callback branch from 134f928 to a868499 Compare March 28, 2024 03:07
dkwingsmt
dkwingsmt reviewed Mar 28, 2024
View reviewed changes
dkwingsmt
dkwingsmt reviewed Mar 28, 2024
View reviewed changes
dkwingsmt
dkwingsmt reviewed Mar 28, 2024
View reviewed changes
dkwingsmt
dkwingsmt reviewed Mar 28, 2024
View reviewed changes
dkwingsmt
dkwingsmt reviewed Mar 28, 2024
View reviewed changes
dkwingsmt
dkwingsmt approved these changes Mar 28, 2024
View reviewed changes
Copy link
Contributor

@dkwingsmt dkwingsmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with comment suggestions

@loic-sharma loic-sharma added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 29, 2024
@auto-submit auto-submit bot merged commit 4ac21cb into flutter:main Mar 29, 2024
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 29, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 29, 2024
@engine-flutter-autoroll
4ac21cb7c Add completion callback to Shell::AddView (flutter/engine…
22cc4d9 
…#51659)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 29, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 29, 2024
@engine-flutter-autoroll
4ac21cb7c Add completion callback to Shell::AddView (flutter/engine…
9ea5a77 
…#51659)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 29, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 29, 2024
@engine-flutter-autoroll
4ac21cb7c Add completion callback to Shell::AddView (flutter/engine…
3a9806e 
…#51659)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 29, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 29, 2024
@engine-flutter-autoroll
4ac21cb7c Add completion callback to Shell::AddView (flutter/engine…
94b9cda 
…#51659)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 29, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 29, 2024
@engine-flutter-autoroll
4ac21cb7c Add completion callback to Shell::AddView (flutter/engine…
3c38fc3 
…#51659)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 29, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 29, 2024
@engine-flutter-autoroll
4ac21cb7c Add completion callback to Shell::AddView (flutter/engine…
7324738 
…#51659)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 29, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 29, 2024
@engine-flutter-autoroll
4ac21cb7c Add completion callback to Shell::AddView (flutter/engine…
d9fde01 
…#51659)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 29, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 29, 2024
@engine-flutter-autoroll
4ac21cb7c Add completion callback to Shell::AddView (flutter/engine…
426534c 
…#51659)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 29, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 29, 2024
@engine-flutter-autoroll
4ac21cb7c Add completion callback to Shell::AddView (flutter/engine…
7535420 
…#51659)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 29, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 29, 2024
@engine-flutter-autoroll
4ac21cb7c Add completion callback to Shell::AddView (flutter/engine…
f6ee3ef 
…#51659)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 29, 2024
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 29, 2024
@engine-flutter-autoroll
4ac21cb7c Add completion callback to Shell::AddView (flutter/engine…
360418d 
…#51659)
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Mar 29, 2024
@engine-flutter-autoroll
Roll Flutter Engine from 68aa9ba386e1 to b16c0f136cdd (10 revisions) (#…
9d6b4f1 
…145990)

flutter/engine@68aa9ba...b16c0f1

2024-03-29 [email protected] Roll Skia from 94c0af1297ae to a12e40efacea (3 revisions) (flutter/engine#51776)
2024-03-29 [email protected] Roll Skia from b2a01ae03cdf to 94c0af1297ae (1 revision) (flutter/engine#51773)
2024-03-29 [email protected] Roll Skia from 6042ad386bcf to b2a01ae03cdf (4 revisions) (flutter/engine#51772)
2024-03-29 [email protected] Roll Fuchsia Linux SDK from uzI3wnbEGlZ_dtO0Z... to 3vgfbp1vjXkdMZ09m... (flutter/engine#51767)
2024-03-29 [email protected] [skwasm] Fix `toString` methods on Paint and ImageFilter/ColorFilter (flutter/engine#51766)
2024-03-29 [email protected] Reland flutter/engine#51391 (flutter/engine#51764)
2024-03-29 [email protected] Add completion callback to `Shell::AddView` (flutter/engine#51659)
2024-03-29 [email protected] [Windows] Move keyboard initialization (flutter/engine#51758)
2024-03-29 [email protected] [Windows] Don't always stop engine on view destruction (flutter/engine#51681)
2024-03-28 [email protected] [macOS] Group per-view information in `FlutterCompositor` into a class (flutter/engine#51738)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from uzI3wnbEGlZ_ to 3vgfbp1vjXkd

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@cbracken cbracken Awaiting requested review from cbracken

1 more reviewer

@dkwingsmt dkwingsmt dkwingsmt approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@loic-sharma @dkwingsmt