This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Implement .engine-release.version files for engine Skia Gold tests
#51739
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matanlurey
commented
Mar 28, 2024
zanderso
approved these changes
Mar 28, 2024
| @@ -0,0 +1,126 @@ | |||
| import 'dart:convert'; | |||
There was a problem hiding this comment.
nit: New files here and below need the engine copyright header.
|
Thanks! Friendly ping @mdebbar @gaaclarke. I promise 90% of the diff is comments/docs/tests. |
gaaclarke
approved these changes
Mar 29, 2024
testing/skia_gold_client/README.md
Outdated
Comment on lines
63
to
69
| - name: Linux linux_android_emulator_tests | ||
| properties: | ||
| config_name: linux_android_emulator | ||
| + dependencies: >- | ||
| + [ | ||
| + {"dependency": "goldctl", "version": "git_revision:720a542f6fe4f92922c3b8f0fdcc4d2ac6bb83cd"} | ||
| + ] |
There was a problem hiding this comment.
Does this render correctly? I would have expected the pluses and minuses at the beginning of the line
There was a problem hiding this comment.
Hmm good point, let me try again
| /// Throws a [FormatException] if the file contents are not in the expected | ||
| /// format (either empty/comments only, or missing a `major.minor` line in | ||
| /// the format described in [ReleaseVersion.new]). | ||
| static ReleaseVersion? parse(String fileContents) { |
There was a problem hiding this comment.
nit: I think this could be 1/3 the size if you use regular expressions.
There was a problem hiding this comment.
Hmm. I hope this is fine, I am not opposed to a regular expression but also hate multi-line regular expressions personally.
|
Thanks! @godofredoc friendly ping as well - I'm not sure you want to review this or not, but I figured I'd give you a chance before merging. |
matanlurey
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 29, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Mar 29, 2024
…146001) flutter/engine@7176173...8480145 2024-03-29 [email protected] Add a minimal example of using `package:test`. (flutter/engine#51726) 2024-03-29 [email protected] Implement `.engine-release.version` files for engine Skia Gold tests (flutter/engine#51739) 2024-03-29 [email protected] [web] Use viewId for text editing (flutter/engine#51099) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work towards flutter/flutter#144835.
Doc (sorry, internal only): go/flutter-engine-goldens-workflow.
This implements the majority of the proposed workflow, that is, optionally having a plain-text version at the root of the directory, and using it to apply a unique suffix we can review in release branches. As it stands, this is a NO-OP outside of tests (it will have no impact, and can be ignored).
What's missing before using this feature in release branches:
Separate tests from builds that generate artifacts flutter#145842
@gaaclarke As implemented, I think we don't need anything special for
dir_contents_diff, but maybe I'm wrong - I think only the test names are being changed, not the names on disk./cc @zanderso as well.