Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

matanlurey
Copy link
Contributor

@matanlurey matanlurey commented Mar 28, 2024

Closes flutter/flutter#144064.

From a conversation with @camsim99 on Discord:

Ah this was to debug that missing emulator issue (flutter/flutter#137947) that Ricardo and I were seeing. We wanted to see if it was specific to the API 34, and if so, escalate the issue internally. @ricardoamador Would you like to keep running the tests with API 33? You mentioned you have found a workaround, and the test runs seem to not have yielded any evidence against API 34.

@matanlurey matanlurey requested a review from camsim99 March 28, 2024 16:22
@matanlurey matanlurey added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 28, 2024
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Mar 28, 2024
Copy link
Contributor

auto-submit bot commented Mar 28, 2024

auto label is removed for flutter/engine/51751, due to - The status or check suite Linux linux_android_emulator_skia_tests has failed. Please fix the issues identified (or deflake) before re-applying this label.

@matanlurey matanlurey added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 28, 2024
@auto-submit auto-submit bot merged commit a8338a4 into flutter:main Mar 28, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 28, 2024
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Mar 28, 2024
…145938)

flutter/engine@c176d11...b917b24

2024-03-28 [email protected] Test that `clangd --check` works at HEAD. (flutter/engine#50901)
2024-03-28 [email protected] Remove `--verbose` from clang_tidy execution on CI. (flutter/engine#51760)
2024-03-28 [email protected] Remove Android API v33 tests from CI. (flutter/engine#51751)
2024-03-28 [email protected] Reland: [Impeller] adds a plus advanced blend for f16 pixel formats (flutter/engine#51756)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

autosubmit Merge PR when tree becomes green via auto submit App

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bringup builds that use Skia gold are now failing

2 participants