This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Fix the clangd builders, and make Linux non-bringup.
#51765
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zanderso
approved these changes
Mar 29, 2024
| drone_dimensions: | ||
| - os=Mac-13 | ||
|
|
||
| - name: Mac clangd |
There was a problem hiding this comment.
optional nit: Not critical, but this orchestrator could be a Linux host to save 5 minutes of mac host time.
There was a problem hiding this comment.
I mean I'm down - where can I read about that/how can I do it?
I am guessing orchestrator == drone_dimensions? Is there another example of this?
There was a problem hiding this comment.
So you'd change Mac clangd to something like Linux mac_clangd, and then add:
drone_dimensions:
- os=Linux
Like in Linux mac_android_aot_engine. Probably has to stay bringup: true in this PR to make sure that works properly.
matanlurey
changed the title
clangd builders, and make them non-bringup.clangd builders, and make Linux non-bringup.
matanlurey
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 29, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Mar 29, 2024
…146010) flutter/engine@4c079a6...4b6836f 2024-03-29 [email protected] Rename `Mac clangd` to `Linux mac_clangd` (flutter/engine#51785) 2024-03-29 [email protected] Fix the `clangd` builders, and make Linux non-bringup. (flutter/engine#51765) 2024-03-29 [email protected] Remove _dartobservatory._tcp legacy DNS registration type (flutter/engine#51635) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Further work towards flutter/flutter#141641.
I could imagine making things
presubmit: falseif we think it's not worth the presubmit capacity.Removed
:copy_dart_sdkwhich seems (a) not to work and (b) not needed to use the pre-builts.